IETF Logo Mail Archive

Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)

ianswett <notifications@github.com> Mon, 19 March 2018 00:30 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 50F231267BB for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 17:30:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.606
X-Spam-Level:
X-Spam-Status: No, score=-0.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hxeQLb8nWiIB for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 17:30:50 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8FDAC126579 for <quic-issues@ietf.org>; Sun, 18 Mar 2018 17:30:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=pu/W7aoaK4ChQ31j32mckUrBvpc=; b=uaL9BNQjDW4ze4lx IKfI37492LFvTr+H9k7Gh7dSv7A0QNg2aIWfbsDvEUFh3y7Eakhnww2eexzqPUwu 6C6DLrX9gb/zxmmsJnmXDeTUu82MTBBwEZDXhWHZa6QA+oBSu9uW5lr7IQdjhjH+ E1AIDJUo9TkkUvGy+FCJkfWYvHs=
Received: by filter0327p1iad2.sendgrid.net with SMTP id filter0327p1iad2-10379-5AAF04B9-5 2018-03-19 00:30:49.361910573 +0000 UTC
Received: from smtp.github.com (out-3.smtp.github.com [192.30.252.194]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id z2ls1HwjTQa52m0FWArPlw for <quic-issues@ietf.org>; Mon, 19 Mar 2018 00:30:49.260 +0000 (UTC)
Date: Mon, 19 Mar 2018 00:30:49 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab15c470db1b9c29e0b176367005e8948cda373ee092cf0000000116c6c6b992a169ce12418d6a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1231/review/104819282@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1231@github.com>
References: <quicwg/base-drafts/pull/1231@github.com>
Subject: Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aaf04b92e802_7b532b0a67636ec8126524"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1OEPm47cWDdra4IzEwJ9FLmNTKs6oq03yTZV FKQKZWVzL6mahGfNsaV7GFFqt8BeV01frHB62Y0L3PBpRYIVz8sgAL33eO7rcwTlIGS9v0fKgEo/mO wpNxzOunN8RKM6aLWYTvzoekzj2RBtJgDLI9oexWSs7qXNsRHb14lGW1gA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5K1X53PCJjOErLdi8whDzxD42Ik>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 00:30:52 -0000

ianswett commented on this pull request.



> @@ -2538,10 +2538,10 @@ ACK Block (repeated):
 Implementations MUST NOT generate packets that only contain ACK frames in
 response to packets which only contain ACK frames. However, they MUST
 acknowledge packets containing only ACK frames when sending ACK frames in
-response to other packets.  Implementations MUST NOT send more than one ACK
-frame per received packet that contains frames other than ACK frames.  Packets
-containing non-ACK frames MUST be acknowledged immediately or when a delayed
-ack timer expires.
+response to other packets.  Implementations MUST NOT send more than one packet
+containing only ACK frames per received packet that contains frames other than

I have no objection, but is the motivation for this the coming CRYPTO_ACK/ACK split?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1231#pullrequestreview-104819282

v2.43.4 | Report a Bug | By Email | System Status