IETF Logo Mail Archive

Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)

Kazu Yamamoto <notifications@github.com> Fri, 17 July 2020 02:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4A2713A0F79 for <quic-issues@ietfa.amsl.com>; Thu, 16 Jul 2020 19:28:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s517MCtzeRPl for <quic-issues@ietfa.amsl.com>; Thu, 16 Jul 2020 19:28:30 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 01B0C3A0F74 for <quic-issues@ietf.org>; Thu, 16 Jul 2020 19:28:29 -0700 (PDT)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id 17DDE6E04A1 for <quic-issues@ietf.org>; Thu, 16 Jul 2020 19:28:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594952909; bh=+J2lUPyCG08TKkxcfMbPcbOp3Aj6ePwvOBwiey6lZbA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oLfGOtEOM8tz4veknzTFGVYyLt8sz/N5+3cSmLZlcbnbgSylzLCd8GyZSz0/tUpZ+ +1SYmTvwYIAIF2RUQBTPsfJTMkjomsa8/V3hnbm9tvjtFDFv8ExgkakObBb9kacf96 fmr8NrDSNDrgLMq3UMdQUC+2PrvB9YHJKi1FF2sQ=
Date: Thu, 16 Jul 2020 19:28:29 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZIAJNUYXEITDKZMMN5DTW43EVBNHHCOPRYC4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3917/c659796276@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3917@github.com>
References: <quicwg/base-drafts/pull/3917@github.com>
Subject: Re: [quicwg/base-drafts] Byte counting at Congestion avoidance (#3917)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f110ccd8a5c_34b13fe1406cd96c8546e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5LXooUw_bwh1DyaXezX1861m5ng>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2020 02:28:31 -0000

I would like to add comments in the following places:
- `/` in `OnPacketAcked`
- `congestion_window *= kLossReductionFactor` in `CongestionEvent`
- "`lost_packets` should be retransmitted" in `OnPacketsLost`
- "`max_ack_delay` is updated when TP exchanged, default to 25ms" in `Initialization`
- "A sender can send bytes of `congestion_window` - `bytes_in_flight`" in `Variables of interest`

They might be trivial for experts but it is difficult for beginners like me to understand the assumptions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3917#issuecomment-659796276

v2.30.2 | Report a Bug | By Email | System Status