Re: [quicwg/base-drafts] Rewrite text about Version Negotiation (#1039)

Kazuho Oku <notifications@github.com> Tue, 13 February 2018 05:36 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F1A712E878 for <quic-issues@ietfa.amsl.com>; Mon, 12 Feb 2018 21:36:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.029
X-Spam-Level:
X-Spam-Status: No, score=-2.029 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Kc88rEC28TA4 for <quic-issues@ietfa.amsl.com>; Mon, 12 Feb 2018 21:36:35 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F5C312E877 for <quic-issues@ietf.org>; Mon, 12 Feb 2018 21:36:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=rRpw91TmfsQ/k/MXDlVB4BA+rfc=; b=IKlsL0/LAh9Vd69u dT5t8AuOkOLNwLeLx4N8uzIjpCCM5Co5CW/FFY9HQFwtOgwoOCL4TsC8cG6qfNpb l+TZrTXl8c+sWIFpqe4BufU2ral4aSpRS5SwXmfoUWD6GvimyMaK+YKXmIrom7WM 5JCMDYEC2m12lOQDcahHPEoZxKE=
Received: by filter0486p1iad2.sendgrid.net with SMTP id filter0486p1iad2-25259-5A827961-A 2018-02-13 05:36:33.998725334 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0020p1iad2.sendgrid.net (SG) with ESMTP id 828AOy-5RWKYGbQliXs24Q for <quic-issues@ietf.org>; Tue, 13 Feb 2018 05:36:34.073 +0000 (UTC)
Date: Tue, 13 Feb 2018 05:36:34 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab71f9f902d91b0321fa9c602cfb36079f0139c07392cf00000001169a3b6192a169ce1115d834@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1039/review/96029865@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1039@github.com>
References: <quicwg/base-drafts/pull/1039@github.com>
Subject: Re: [quicwg/base-drafts] Rewrite text about Version Negotiation (#1039)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a827961e6be6_44e13fe91afd8f3449439d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak23o49oCHYt94ICk6iSgkGr1nlqPqv7XPa7nx 4rUzrgy5nurJI8VZy+j0BaaJb2Gdvg1ZvRJQ0D+lR5u3fPwyfHddcc5fIeKNFR5IzqVbdM+/JQM2yS KLzyF9zi+ggAVfA9UOZCCm89MJfWl4ZLmEmUNWnNMd2Za9PsAdA26NTxSavSc80U3ho6EmPeY/icJf 0=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5PNHPZ5iJArAq_9taZMtQxRl-gs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Feb 2018 05:36:37 -0000

kazuho commented on this pull request.



> -used - and they MUST be padded to at least 1200 octets.
-
-The server receives this packet and determines whether it potentially creates a
-new connection (see {{packet-handling}}).  If the packet might generate a new
-connection, the server then checks whether it understands the version that the
-client has selected.
-
-If the packet contains a version that is acceptable to the server, the server
-proceeds with the handshake ({{handshake}}).  This commits the server to the
-version that the client selected.
+with an existing connection, or - for servers - potentially create a new
+connection.
+
+First, hosts try to associate the packet with an existing connection. If the
+packet has a connection ID corresponding to an existing connection, QUIC
+processes that packet accordingly. Note that a NEW_CONNECTION_ID frame

> If the packet has a connection ID corresponding to an existing connection, QUIC processes that packet accordingly.

May I ask if this is true?

In current form of QUIC, a server is allowed to specify any Connection ID that it likes, which may collide with a Connection ID that a client chooses for a new connection.

I believe that a client needs to identify 1 RTT packets by their 5-tuple to avoid the issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1039#pullrequestreview-96029865