Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 4CA781200EB
 for <quic-issues@ietfa.amsl.com>; Sat, 22 Jun 2019 22:42:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.391
X-Spam-Level: 
X-Spam-Status: No, score=-6.391 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001,
 MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id UjLCV9pM7FmU for <quic-issues@ietfa.amsl.com>;
 Sat, 22 Jun 2019 22:41:58 -0700 (PDT)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 8CA7F1200A4
 for <quic-issues@ietf.org>; Sat, 22 Jun 2019 22:41:58 -0700 (PDT)
Date: Sat, 22 Jun 2019 22:41:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1561268517;
 bh=kDtoq/BVWIjt6+LPzS57LIntqC0ZeIcttmpolsbjRnw=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=uE2PS5eIN/z0zminWtTLbkw4pBAN/ziIKCvsAR/CMg3CM/djc+D2eK7W5ezOZK49U
 2mW5Kd8bG4IjzhmSt6fTdoxUAL6hdWbyQ8n0Yc3+07gdeSF2ukTMKaKIjuAVtNOsie
 G8DkU7Cv8zZzLhSImc/PpMn3uBhDN8HrkKNiEnrk=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK62FIVUQHCDHCPWHZ53DRB2LEVBNHHBQDIQME@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2370/review/253116590@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2370@github.com>
References: <quicwg/base-drafts/pull/2370@github.com>
Subject: Re: [quicwg/base-drafts] Stronger migration handshake (#2370)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d0f11256dbd5_7a303fdbc3acd96836404a";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5QBfIaNW_SrBmPOQhXGkK_Cl0RM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jun 2019 05:42:00 -0000


----==_mimepart_5d0f11256dbd5_7a303fdbc3acd96836404a
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

huitema commented on this pull request.



>  endpoints retaining a stable address for the duration of the handshake.
+An endpoint MUST NOT initiate connection migration before the handshake is
+finished for it and its peer and the endpoint has 1-RTT keys. This means
+that the server MUST NOT initiate connection migration before it has
+received at least one 1-RTT data from the client, and the client 
+MUST NOT initiate connection migration before receiving 
+acknowledgement by the server of at least one of its
+1-RTT messages.

Solved in rewrite with dependency on "handshake confirmed".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2370#discussion_r296465803
----==_mimepart_5d0f11256dbd5_7a303fdbc3acd96836404a
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@huitema</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2370#discussion_r296465803">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  endpoints retaining a stable address for the duration of the handshake.
+An endpoint MUST NOT initiate connection migration before the handshake is
+finished for it and its peer and the endpoint has 1-RTT keys. This means
+that the server MUST NOT initiate connection migration before it has
+received at least one 1-RTT data from the client, and the client 
+MUST NOT initiate connection migration before receiving 
+acknowledgement by the server of at least one of its
+1-RTT messages.
</pre>
<p>Solved in rewrite with dependency on "handshake confirmed".</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2370?email_source=notifications&amp;email_token=AFTOJK27YYWQU4VHS36VDODP34EKLA5CNFSM4GSSCBF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LEBLQ#discussion_r296465803">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK5ISTAZGK4B34HB4MTP34EKLANCNFSM4GSSCBFQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK6OT6KCRTN5GGWQLM3P34EKLA5CNFSM4GSSCBF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LEBLQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2370?email_source=notifications\u0026email_token=AFTOJK27YYWQU4VHS36VDODP34EKLA5CNFSM4GSSCBF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LEBLQ#discussion_r296465803",
"url": "https://github.com/quicwg/base-drafts/pull/2370?email_source=notifications\u0026email_token=AFTOJK27YYWQU4VHS36VDODP34EKLA5CNFSM4GSSCBF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LEBLQ#discussion_r296465803",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d0f11256dbd5_7a303fdbc3acd96836404a--

