Date: Tue, 08 Jan 2019 11:06:18 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab190849e4a4abe3f6fd940e24d9ebeec4a971cc9b92cf00000001184cb6aa92a169ce17856d43@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2268/c452415035@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2268@github.com>
References: <quicwg/base-drafts/pull/2268@github.com>
Subject: Re: [quicwg/base-drafts] only require RESET_STREAM on STOP_SENDING in
 Ready and Sent state (#2268)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c34f4aa2e92a_7b063fab472d45c41977db";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5SnZnYkvkV7bIHlv_wI__YvVxUE>


----==_mimepart_5c34f4aa2e92a_7b063fab472d45c41977db
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

Receiving a FIN isn't enough to complete the state machine, though some implementations might short-circuit it when sending a STOP_SENDING.  The reliability machinery expects to send all data declared lost unless there's a RESET_STREAM.  I think the language needs to be something like:

> ...MUST send a RESET_STREAM frame if the stream is in the Ready or Send state.  If the stream is in the Data Sent state and any outstanding data is declared lost, an endpoint SHOULD send a RESET_STREAM frame in lieu of a retransmission.

(This effectively makes a new side state from Data Sent where you're waiting to decide if you need to send a RESET_STREAM.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2268#issuecomment-452415035
----==_mimepart_5c34f4aa2e92a_7b063fab472d45c41977db
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>Receiving a FIN isn't enough to complete the state machine, though som=
e implementations might short-circuit it when sending a STOP_SENDING.  Th=
e reliability machinery expects to send all data declared lost unless the=
re's a RESET_STREAM.  I think the language needs to be something like:</p=
>
<blockquote>
<p>...MUST send a RESET_STREAM frame if the stream is in the Ready or Sen=
d state.  If the stream is in the Data Sent state and any outstanding dat=
a is declared lost, an endpoint SHOULD send a RESET_STREAM frame in lieu =
of a retransmission.</p>
</blockquote>
<p>(This effectively makes a new side state from Data Sent where you're w=
aiting to decide if you need to send a RESET_STREAM.)</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/2268#issuecomment-452415035">view it on GitHub</a>, o=
r <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq7lhL6=
edm0qKCHaMulM6l9GSD4nBks5vBOwqgaJpZM4Zjx3_">mute the thread</a>.<img src=3D=
"https://github.com/notifications/beacon/AWbkq19Pv0oXgz-xU9JUGoJGT3e-ATyn=
ks5vBOwqgaJpZM4Zjx3_.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://github.githubassets.com/images/email/message_cards/header.png","avata=
r_image_url":"https://github.githubassets.com/images/email/message_cards/=
avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/q=
uicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@=
MikeBishop in #2268: Receiving a FIN isn't enough to complete the state m=
achine, though some implementations might short-circuit it when sending a=
 STOP_SENDING.  The reliability machinery expects to send all data declar=
ed lost unless there's a RESET_STREAM.  I think the language needs to be =
something like:\r\n\r\n\u003e ...MUST send a RESET_STREAM frame if the st=
ream is in the Ready or Send state.  If the stream is in the Data Sent st=
ate and any outstanding data is declared lost, an endpoint SHOULD send a =
RESET_STREAM frame in lieu of a retransmission.\r\n\r\n(This effectively =
makes a new side state from Data Sent where you're waiting to decide if y=
ou need to send a RESET_STREAM.)"}],"action":{"name":"View Pull Request",=
"url":"https://github.com/quicwg/base-drafts/pull/2268#issuecomment-45241=
5035"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2268#issuecomment-4=
52415035",
"url": "https://github.com/quicwg/base-drafts/pull/2268#issuecomment-4524=
15035",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>=

----==_mimepart_5c34f4aa2e92a_7b063fab472d45c41977db--