Re: [quicwg/base-drafts] Restore other state after a spoofed migration (#3229)

ianswett <notifications@github.com> Tue, 12 November 2019 21:32 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D3229120127 for <quic-issues@ietfa.amsl.com>; Tue, 12 Nov 2019 13:32:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id afV4-UArWsuK for <quic-issues@ietfa.amsl.com>; Tue, 12 Nov 2019 13:32:49 -0800 (PST)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12D871200EB for <quic-issues@ietf.org>; Tue, 12 Nov 2019 13:32:49 -0800 (PST)
Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 85C49120280 for <quic-issues@ietf.org>; Tue, 12 Nov 2019 13:32:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573594368; bh=NSDzdFzAUlYxYUkGrtQqEYJb/UzPpiREN/DA9xk7bf4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RgqUWJPlUILeMREK0IHeTLXO7OMsOlZtasnwMW4B9xrR1vwlxu2K7KTDxJ8mco8or L4RfHiLbFN8ZGfrYgOK3yE79BdajqIAQl4tmIbPzsWMqzwLSDPViIioEWNxaOfzjL0 Zym3NutCkmkn2RY92TQTPV2WlkNMVxtQvxKDTAJE=
Date: Tue, 12 Nov 2019 13:32:48 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2ZOH7LRG2PUQB4BQV33BLYBEVBNHHB6EX4RU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3229/review/315858318@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3229@github.com>
References: <quicwg/base-drafts/pull/3229@github.com>
Subject: Re: [quicwg/base-drafts] Restore other state after a spoofed migration (#3229)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dcb2500411f1_7a33ff134acd9641455315"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5VFe4gUXMvLycgb9VudDW4pzKOA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Nov 2019 21:32:51 -0000

ianswett commented on this pull request.



> @@ -1979,7 +1979,10 @@ to verify the peer's ownership of the unvalidated address.
 An endpoint MAY send data to an unvalidated peer address, but it MUST protect
 against potential attacks as described in {{address-spoofing}} and
 {{on-path-spoofing}}.  An endpoint MAY skip validation of a peer address if that
-address has been seen recently.
+address has been seen recently.  In particular, if an endpoint returns to a
+previously-validated path after detecting some form of spurious migration,
+skipping address validation and restoring loss detection and congestion state
+can reduce the performance impact of the attack.

The way I think about this is that the old address validation and congestion state are maintained until the new address is validated.  ie: In my thinking, the responder never left the original path.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3229#pullrequestreview-315858318