Re: [quicwg/base-drafts] Allow longer CIDs (#2749)

martinduke <notifications@github.com> Tue, 25 June 2019 22:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1CA11200EF for <quic-issues@ietfa.amsl.com>; Tue, 25 Jun 2019 15:24:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TciiUP4vgwvH for <quic-issues@ietfa.amsl.com>; Tue, 25 Jun 2019 15:24:05 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDECF1205E0 for <quic-issues@ietf.org>; Tue, 25 Jun 2019 15:24:05 -0700 (PDT)
Date: Tue, 25 Jun 2019 15:24:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561501445; bh=OKd3uJS1EPGd/DMZjGTP8lOJTVFY8S81qv/oqqQjQkc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tciEEH73KaGfhLFeOD6NVqOlm4C41yZdXDhcEFMY6O5gDaWQrDuDPPv8R4GDqHv4b ZFTwg3rSiXBaVq2Zh6yDsPyHFM/LZ2a854asovyeiUxsBC/u/77cth6hyCgnLQGcKS B7b+Wzf3Pf8V2wmS/2nHORDHrSbnLOdEJyhNYpt4=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK47YP7NKTDXATXJDTN3D7IYLEVBNHHBVJ2RLQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2749/review/254301263@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2749@github.com>
References: <quicwg/base-drafts/pull/2749@github.com>
Subject: Re: [quicwg/base-drafts] Allow longer CIDs (#2749)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d129f0519648_36f63ff8b28cd968120599"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5evlhhiMBPmXRYlZ_v9x3A6QGWQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Jun 2019 22:24:08 -0000

martinduke commented on this pull request.



> -is also 0 bytes in length.  Non-zero encoded lengths are increased by 3 to get
-the full length of the connection ID; the final value is therefore either 0 or
-between 4 and 18 bytes in length (inclusive).  For example, an byte with the
-value 0xe0 describes a 17 byte Destination Connection ID and a zero byte Source
-Connection ID.
-
-The connection ID lengths are followed by two connection IDs.  The connection
-ID associated with the recipient of the packet (the Destination Connection ID)
-is followed by the connection ID associated with the sender of the packet (the
-Source Connection ID).
+The next byte contains the length in bytes of the destination Connection ID
+(see {{connection-id}}) that follows.  The length is encoded as an 8-bit
+unsigned integer. This is followed by the destination Connection ID itself,
+associated with the receiver of the packet.
+
+The next two fields are the Connection ID length for the source and the source

I am happy to commit this, but it's 'outdated'. Can you update?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2749#discussion_r297418208