IETF Logo Mail Archive

Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)

ianswett <notifications@github.com> Tue, 22 October 2019 04:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AF986120058 for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:28:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Se-UWEtoqwGu for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:28:14 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 98FF712004F for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:28:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ohSrabSGpHn90lcJ8XHgi1FuQLQ=; b=e7EhQYT+3gNWlKtp 6+kuZ/ch77Va9rnXTxpTWdTXx3u+gGcJE4ID07uvKLnBjiHzjuywywzXwdJn0RbW KozCyRFom51kHGlMpBj1FGh9Z4UWDpg2ncpV5QuiA+/L/QPcvxo7dBU1TsbXBx2t Bs5vmcNnjmXM/rP4XOWO3vuISKI=
Received: by filter1453p1las1.sendgrid.net with SMTP id filter1453p1las1-28144-5DAE75C6-10 2019-10-22 03:21:42.362383201 +0000 UTC m=+363836.112836403
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) by ismtpd0013p1iad2.sendgrid.net (SG) with ESMTP id La1vkEakSGqBPa0uLJnmZQ for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:21:42.229 +0000 (UTC)
Received: from github-lowworker-6b40fdd.va3-iad.github.net (github-lowworker-6b40fdd.va3-iad.github.net [10.48.16.64]) by smtp.github.com (Postfix) with ESMTP id CC822A1170 for <quic-issues@ietf.org>; Mon, 21 Oct 2019 20:21:36 -0700 (PDT)
Date: Tue, 22 Oct 2019 03:21:42 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7ZAJWGL2EUDVLJYY53XO3FBEVBNHHB4ST4NM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3107/review/304948803@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3107@github.com>
References: <quicwg/base-drafts/pull/3107@github.com>
Subject: Re: [quicwg/base-drafts] Immediately close with INVALID_TOKEN (#3107)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae75c0bd964_20a43f9d842cd95c141363"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2UHbeuTiC25Z3j/6Zikze4vW1LORg79VuCZ1 iNWQtXXhHCoZaEUElivbiAblUNlrwZbhd8mfxnQiB2/++ImocLTSRkHtekGcdi+eD2VCiqfLyMgDg3 HAJHtGtUf50A9/N/+S0hZMBCYcJSBuBW3+TyDMzOtWF4osz+M1SazktS/84b9yk9am5F2y/O7eaml9 E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5jljivzlt8iz-xf2l-6fnzaZEio>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:28:17 -0000

ianswett commented on this pull request.



> @@ -1641,6 +1641,14 @@ of connection establishment.  By giving the client a different connection ID to
 use, a server can cause the connection to be routed to a server instance with
 more resources available for new connections.
 
+If a server receives a client Initial with a unverifiable Retry token,
+it knows the client will not accept another Retry token.  It can either
+proceed with the handshake without verifying the token or immediately close

The server could decide it's not under heavy load and proceed with the handshake, even if the token doesn't constitute address validation.  ie: The token could expire on a shorter timeline than the session ticket/etc, so 0-RTT could succeed, but address validation would fail.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3107#discussion_r337318691

v2.29.0 | Report a Bug | By Email | System Status