Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Junho Choi <notifications@github.com> Tue, 19 November 2019 03:14 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 098931207FD for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 19:14:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fcbmd2-str2y for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 19:14:36 -0800 (PST)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6E0F2120255 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 19:14:36 -0800 (PST)
Date: Mon, 18 Nov 2019 19:14:35 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574133276; bh=4EtTpR47yilar/iwe+MfGCadREaHpX8VeLmZpAQPsOk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=T26gkWXbHsGz1iIHecshdkOdO+7atuRV97WlXETkpNltIwAZhVms9YfxCCfuRNNlV ExAaXwP1K0BYQ9pAG85AezIk/m65HNl9Z11G48JgvRvqkr06F6ZyKMowyIrnlnzpMM C8/HQyg9C1HoYZcKjf1r+3hYteefrxO0P39UrRWo=
From: Junho Choi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYZAZHDOZL6CVYYC3F34CIJXEVBNHHB6GTRAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3232/review/318762485@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3232@github.com>
References: <quicwg/base-drafts/pull/3232@github.com>
Subject: Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd35e1bd779c_3ed53feeca8cd96411009a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: junhochoi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5lAXsqT9_67IAd1suH5BbP6fytc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 03:14:38 -0000
junhochoi commented on this pull request. > @@ -1369,7 +1378,17 @@ acked_packet from sent_packets. return if (congestion_window < ssthresh): // Slow start. - congestion_window += acked_packet.size + if (pacing): + congestion_window += acked_packet.size + else: + // If pacing is not used, limit the increase to + // 2*max_datagram_size per ACK as described in ```suggestion // 2 * max_datagram_size per ACK as described in ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3232#pullrequestreview-318762485
- [quicwg/base-drafts] Limit CWND increase in slow … Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Martin Thomson
- Re: [quicwg/base-drafts] Limit CWND increase in s… Junho Choi
- Re: [quicwg/base-drafts] Limit CWND increase in s… ianswett
- Re: [quicwg/base-drafts] Limit CWND increase in s… Jana Iyengar
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel
- Re: [quicwg/base-drafts] Limit CWND increase in s… Vidhi Goel