Re: [quicwg/base-drafts] New connection IDs are mandatory for intentional migration (#2414)

erickinnear <notifications@github.com> Wed, 13 February 2019 01:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD7C2130E7D for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 17:33:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J0vvAvMHdvSZ for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 17:33:48 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BBDC9129284 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 17:33:47 -0800 (PST)
Date: Tue, 12 Feb 2019 17:33:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550021626; bh=kWDi5QCec/PdDuyC1XBkyrOFU3v9pPVCimPrfpvSr48=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=qLSGOhyzW3IfOpmsfpPUaw1tqZX/vU0lQ8M3OEdknCjUZVbDnqFnRbWMqnnXDz9NF C7m06yutRSIbYxGizLmNIrb0DRnqU0aZ7hpGOMpSZd+eoxN3SBBZVamxrof63GCHVh 6AWidJ2qhKTc94/dprdU59K5gei8ji7isoDEfh+4=
From: erickinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab08e7aad278eea8894ca1c0e6eabea8dfc981253992cf00000001187b35fa92a169ce183ba47d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2414/review/202969444@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2414@github.com>
References: <quicwg/base-drafts/pull/2414@github.com>
Subject: Re: [quicwg/base-drafts] New connection IDs are mandatory for intentional migration (#2414)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6373fab20e6_b953fb9c5ad45bc54613"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5lMLkKhdHr3oALL1-SaY-BAx5qk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 01:33:50 -0000

erickinnear approved this pull request.

Looks like good clarification, just one minor wording comment

> @@ -1853,7 +1853,9 @@ An endpoint also MUST NOT initiate connection migration if the peer sent the
 `disable_migration` transport parameter during the handshake.  An endpoint which
 has sent this transport parameter, but detects that a peer has nonetheless
 migrated to a different network MAY treat this as a connection error of type
-INVALID_MIGRATION.
+INVALID_MIGRATION.  Similarly, an endpoint MUST NOT migrate if its peer supplies

It would probably be worth indicating that this is intentional migration, just to keep everything clear. Elsewhere I think we've said an endpoint must not "initiate" migration, since of course its peer may think it migrated due to a NAT. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2414#pullrequestreview-202969444