Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)

ianswett <notifications@github.com> Wed, 13 November 2019 00:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4896F1200B5 for <quic-issues@ietfa.amsl.com>; Tue, 12 Nov 2019 16:26:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hb9Vz0no7aSQ for <quic-issues@ietfa.amsl.com>; Tue, 12 Nov 2019 16:26:29 -0800 (PST)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 94582120044 for <quic-issues@ietf.org>; Tue, 12 Nov 2019 16:26:29 -0800 (PST)
Date: Tue, 12 Nov 2019 16:26:27 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573604788; bh=//EmffgqkvQO9mthC30hfu6uLNnphUKLLGN3HxuTico=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Q6LiGXkli3U0XqVvg8NQvMeiNJiz+agzMAMGfeBcIPEa9EtgRhBpcK8wVpmRQNUzW UuNuKI4ERKiEbPB/crxz62oDObOuFWIkEQqFzBySO+t8iVnM2thNFKPtYGSG8ogA6V mZKhTWbY+PampiGoA8Nlse6QqBtTN3Rqj1pIdxUs=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZZDKSN2YZALSM6C6F33CADHEVBNHHB6GTRAA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3232/c553180443@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3232@github.com>
References: <quicwg/base-drafts/pull/3232@github.com>
Subject: Re: [quicwg/base-drafts] Limit CWND increase in slow start (#3232)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dcb4db3cf232_53443ffbe16cd9601705aa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5wGXtFFdEiZlfwCOF_6aLNO9dks>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Nov 2019 00:26:32 -0000

Thanks for your PR, it's helpful to see this clarified.

I think it's worth a discussion of two issues, maybe in Singapore:
1) Do we need anything in addition to the existing IW burst limit?  A single ACK loss would not cause a burst to exceed the IW10 limit, and multiple consecutive ACK losses in slow start are VERY rare in my experience.
2) Do we need to describe the non-pacing scenarios in the pseudocode, given we recommend pacing?  Using CWND to manipulate sending behavior is an indirect method that feels like a holdover from implementation details of older TCP algorithms to me.

I'm no on both counts currently, but if the WG feels otherwise, I can accept that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3232#issuecomment-553180443