Re: [quicwg/base-drafts] http-core and Friends (#3513)

Bence Béky <notifications@github.com> Thu, 26 March 2020 12:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1FBB33A0CEC for <quic-issues@ietfa.amsl.com>; Thu, 26 Mar 2020 05:27:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HiMsS6lQblw9 for <quic-issues@ietfa.amsl.com>; Thu, 26 Mar 2020 05:27:53 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 46BEA3A085B for <quic-issues@ietf.org>; Thu, 26 Mar 2020 05:27:53 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 47B9FE024E for <quic-issues@ietf.org>; Thu, 26 Mar 2020 05:27:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585225672; bh=p2cR28mPcd5dN+Y/3f0Yu64jI4fXdSeYehmLexfy74I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=KdqqpZxwd97amyfR2fK7rTYujZ4cjd17NKuDGgd/a0KKBmiWGDJ2cZQ1ebwo5bxFG KkmfIjceiTLLrkby//bp/U6O1qdGqILbE+QETkfCm+0icqTNQ/QMSddeQFcYjegnpf X2HkkofQg3J0T7QKTUHomAD+Pfd6YsidGItosBUw=
Date: Thu, 26 Mar 2020 05:27:52 -0700
From: =?UTF-8?B?QmVuY2UgQsOpa3k=?= <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5OL667LHUYREVHB2F4RCAMREVBNHHCFCTWBI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3513/review/381108014@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3513@github.com>
References: <quicwg/base-drafts/pull/3513@github.com>
Subject: Re: [quicwg/base-drafts] http-core and Friends (#3513)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e7c9fc837793_67253fb7c2ccd968286512"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/5zupadfJAy9Fh9iuWL3zJjC2e6c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Mar 2020 12:27:55 -0000

@bencebeky requested changes on this pull request.

LGTM modulo nits.

>  
 #### Pseudo-Header Fields
 
-As in HTTP/2, HTTP/3 uses special pseudo-header fields beginning with the ':'
-character (ASCII 0x3a) to convey the target URI, the method of the request, and
-the status code for the response.
+As in HTTP/2, HTTP/3 uses a series of pseudo-header field lines beginning with

Why "field lines" not "fields"?  Focus is on semantics, not representation.

>  
 #### Pseudo-Header Fields
 
-As in HTTP/2, HTTP/3 uses special pseudo-header fields beginning with the ':'
-character (ASCII 0x3a) to convey the target URI, the method of the request, and
-the status code for the response.
+As in HTTP/2, HTTP/3 uses a series of pseudo-header field lines beginning with
+the ':' character (ASCII 0x3a) to convey the target URI, the method of the

It is not the field lines or fields that being with the ':' character, but the field name.  Maybe "a series of pseudo-fields with field name beginning with the ':' character"?

>  pseudo-header fields other than those defined in this document, except as
 negotiated via an extension; see {{extensions}}.
 
-Pseudo-header fields are only valid in the context in which they are defined.
-Pseudo-header fields defined for requests MUST NOT appear in responses;
-pseudo-header fields defined for responses MUST NOT appear in requests.
-Pseudo-header fields MUST NOT appear in trailers.  Endpoints MUST treat a
-request or response that contains undefined or invalid pseudo-header fields as
-malformed ({{malformed}}).
+Pseudo-fields are only valid in the context in which they are defined.

"Pseudo-field" is used here without any introduction.  Another problem is that the punctuation in "pseudo-header field" is misleading: it is a header field that is pseudo, not a field that is pseudo-header.  "Pseudo header-field" would be more accurate, but clumsy.  I recommend removing "pseudo-header field" entirely and only using "pseudo-field".  Then first sentence of this section becomes "As in HTTP/2, HTTP/3 uses a series of pseudo-fields in the header field section".

>  
 #### Pseudo-Header Fields
 
-As in HTTP/2, HTTP/3 uses special pseudo-header fields beginning with the ':'
-character (ASCII 0x3a) to convey the target URI, the method of the request, and
-the status code for the response.
+As in HTTP/2, HTTP/3 uses a series of pseudo-header field lines beginning with

"As in HTTP/2, HTTP/3 uses" does not make sense.  A subject is missing: who is using pseudo-headers in HTTP/2.  It would be better to write either "Like HTTP/2, HTTP/3 uses" or "As in HTTP/2, in HTTP/3 one uses".

>  promises. When the same Push ID is promised on multiple request streams, the
-decompressed request header sets MUST contain the same fields in the
+decompressed request field sets MUST contain the same fields in the

"field set" is not defined in SEMANTICS.  Maybe "field sections" would be more appropriate?

> @@ -1308,7 +1310,7 @@ peer combines the two sets to conclude which choice will be used.  SETTINGS does
 not provide a mechanism to identify when the choice takes effect.
 
 Different values for the same parameter can be advertised by each peer. For
-example, a client might be willing to consume a very large response header,
+example, a client might be willing to consume a very large response field set,

Maybe "field section" instead of "field set", because "field set" is not defined in SEMANTICS.

> @@ -1410,15 +1412,15 @@ error of type H3_SETTINGS_ERROR.
 ### PUSH_PROMISE {#frame-push-promise}
 
 The PUSH_PROMISE frame (type=0x5) is used to carry a promised request header
-set from server to client on a request stream, as in HTTP/2.
+field set from server to client on a request stream, as in HTTP/2.

Maybe "field section" instead of "field set", because "field set" is not defined in SEMANTICS.

> @@ -1445,7 +1447,7 @@ order, and both the name and the value in each field MUST be exact
 matches. Clients SHOULD compare the request header sets for resources promised
 multiple times. If a client receives a Push ID that has already been promised
 and detects a mismatch, it MUST respond with a connection error of type
-H3_GENERAL_PROTOCOL_ERROR. If the decompressed header sets match exactly, the
+H3_GENERAL_PROTOCOL_ERROR. If the decompressed field sets match exactly, the

Maybe "field sections"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3513#pullrequestreview-381108014