Re: [quicwg/base-drafts] GOAWAY means no more (#3338)

ianswett <notifications@github.com> Wed, 15 January 2020 01:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E694D12006D for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:52:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id duvX_cB1vokg for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:52:18 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B4395120058 for <quic-issues@ietf.org>; Tue, 14 Jan 2020 17:52:18 -0800 (PST)
Date: Tue, 14 Jan 2020 17:52:18 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579053138; bh=gDzGZDSKLpLW2DxqK2e+rMcCBlqDazGU94T4Znh2HFA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DWut+wHUz56KMEe7aPJK5NqqxZfzmWjpsvTDasYos84WxoEk21xUdRa9RO0atGj8M fp24Tlt1Eo8Qi3H4crRwl4HdkF6DYejDrbqmtrcpsTwpL/bvDo2XSelZnLm6YfqaGS k3yvGU+oslTIbJN9uwy2Jn+zMOELQCHrrPTpnSI8=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYMDEV7IIDKNTTCEBN4FORNDEVBNHHCBPAYFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3338/review/342949006@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3338@github.com>
References: <quicwg/base-drafts/pull/3338@github.com>
Subject: Re: [quicwg/base-drafts] GOAWAY means no more (#3338)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1e705216dd_72f33f9ef9ecd95c27437d"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/67WjcQNR69iJ9u-MalIBCeTq_mE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 01:52:20 -0000

ianswett commented on this pull request.



> +Before closing the connection, a GOAWAY frame MAY be sent to allow the client to
+retry some requests.  Including the GOAWAY frame in the same packet as the QUIC
 CONNECTION_CLOSE frame improves the chances of the frame being received by
 clients.

Then likely the CONNECTION_CLOSE will be processed before the GOAWAY and the receiver will process the CONNECTION_CLOSE and ignore the GOAWAY.  I think that's how this has to work, but maybe I'm wrong?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3338#discussion_r366662606