Re: [quicwg/base-drafts] Tolerate unknown stream types, add greasing (#1525)

Lucas Pardue <notifications@github.com> Fri, 06 July 2018 21:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BCE9131054 for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 14:56:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xrokGKogHHHR for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 14:56:47 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 87F68131055 for <quic-issues@ietf.org>; Fri, 6 Jul 2018 14:56:47 -0700 (PDT)
Date: Fri, 06 Jul 2018 14:56:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530914206; bh=CN18yRIdzV2Rta8pbmQ81X3PV7+R0S4sYARuzUkEdU0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kzTWI9q4Mry/jJ5oxdoIcH1Lcvisbj3Zmk+JwA6YchexjdbxEIS8FyXZHDTeKtCLR lzsy89hLIq76fvyJQnse3z4fhp1PoUQxtlib0jB1YbUe67/qb29Kq6jsf5wdR5pMtU SusS4B9RHYieemYUEwIJsUinKCKDGNTx7fKFeNLU=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7acceb2752a3c428461cc4eec64686f2cc63d86192cf000000011757a79e92a169ce142f90e7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1525/review/135168315@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1525@github.com>
References: <quicwg/base-drafts/pull/1525@github.com>
Subject: Re: [quicwg/base-drafts] Tolerate unknown stream types, add greasing (#1525)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3fe59edc496_77503fd46dc00f7c8598d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6DXzU1ll6VdH_Yp9XVuFabBkdwU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 21:56:50 -0000

LPardue commented on this pull request.



>  
 If the stream header indicates a stream type which is not supported by the
-recipient, this SHOULD be treated as a stream error of type
-HTTP_UNKNOWN_STREAM_TYPE.  The semantics of the remainder of the stream are
-unknown. Implementations SHOULD NOT send stream types the peer is not already
-known to support, since a stream error can be promoted to a connection error at
-the peer's discretion (see {{errors}}).
+recipient, the remainder of the stream cannot be consumed as the semantics are
+unknown. Recipients of unknown stream types MAY trigger a QUIC STOP_SENDING
+frame with an error code of HTTP_UNKNOWN_STREAM_TYPE, but MUST NOT consider such
+streams to be an error of any kind.
+
+Implementations SHOULD NOT send stream types the peer is not already known to
+support.   Stream types which could modify the state or semantics of existing

If you want to make that change it would make sense to add the sentence from this paragraph to the previous one e.g. 

_Implementations MAY send stream types the peer is not already known to support. If the recipient does not support a stream type, the remainder of the stream cannot be consumed as the semantics are unknown. (optional: add comment about wasted bandwidth)..._

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1525#discussion_r200780118