Re: [quicwg/base-drafts] Define NAT rebinding better (#1501)

Mike Bishop <notifications@github.com> Fri, 29 June 2018 17:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0E3C5130DFB for <quic-issues@ietfa.amsl.com>; Fri, 29 Jun 2018 10:16:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BnsJGbjLBYTP for <quic-issues@ietfa.amsl.com>; Fri, 29 Jun 2018 10:16:41 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ED7F1130DE8 for <quic-issues@ietf.org>; Fri, 29 Jun 2018 10:16:40 -0700 (PDT)
Date: Fri, 29 Jun 2018 10:16:39 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530292599; bh=F9N84jP9NLUYVQ8xam0olrKEtXw8PENLr2SDthUYPqM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=u+SmZ8iWiady2KXfXQi6ALc0Qkg9EfR6x8Nbq9KoXCEmeRCpjRPHEx7TrqRI4JUht B9I0cBxuLi966W1IYn7HFPyRkanwwyD73FII3xMkrQ0v5Fz5M4/3UV7YyV+ciO2lO0 /8sIc/g92XEHIfjkWTofsYnQUR+W0AeMDZ+1gRBw=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3aa4e5736420f8e82f0ccad586363ecc667ca21b92cf00000001174e2b7792a169ce1414837f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1501/review/133308729@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1501@github.com>
References: <quicwg/base-drafts/pull/1501@github.com>
Subject: Re: [quicwg/base-drafts] Define NAT rebinding better (#1501)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b36697718d65_28912b1d4d0a2f5413718b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6JBZ3AFsRENSNfzwfYyLsOP202U>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 17:16:46 -0000

MikeBishop approved this pull request.



> -note that not all changes of peer address are intentional migrations. The peer
-could experience an unintended change of address due to NAT rebinding; endpoints
-SHOULD perform path validation ({{migrate-validate}}) if the rebinding does not
-cause the connection to fail.
+finished and the endpoint has 1-RTT keys.  The design of QUIC relies on
+endpoints retaining a stable address for the duration of the handshake.
+
+An endpoint also MUST NOT initiate connection migration if the peer sent the
+`disable_migration` transport parameter during the handshake.  An endpoint which
+has sent this transport parameter, but detects that a peer has nonetheless
+migrated to a different network MAY treat this as a connection error of type
+INVALID_MIGRATION.
+
+Not all changes of peer address are intentional migrations. The peer could
+experience NAT rebinding: a change of address due a middlebox, usually a NAT,
+allocating a new outgoing IP address and port for a flow.  Endpoints SHOULD

Typically, but not universally.  I agree with "and/or", or perhaps even making the levels differ more -- "allocating a new port or even a new outgoing IP address for a flow."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133308729