Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
ianswett <notifications@github.com> Thu, 20 December 2018 21:41 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 294FF130F72 for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 13:41:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tnbMh44zA-5t for <quic-issues@ietfa.amsl.com>; Thu, 20 Dec 2018 13:41:47 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33D74130F0B for <quic-issues@ietf.org>; Thu, 20 Dec 2018 13:41:47 -0800 (PST)
Date: Thu, 20 Dec 2018 13:41:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545342106; bh=Y5EzClsjNe3w1hw4bn4iKAskvvAl1QnwA4brHlpoDMw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rRl3FmFNnqPdEAtdaw5Upp4NG6gvdAE610C32LT8yv9ewfYXXI75Cs1z9g84SvYzR /GrUvWocNWJIen+NOxLG6coIhbvf9N5yRcFpyIwklJEH6VH/6MzSnDJUBwi6DZS7H5 1BPVVjr56xgPkcuxI3c7JXn7yv1JeAskv61jxhEg=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcca7753462477ee1a646dff443767d2151e545c392cf000000011833ce9a92a169ce176a63e1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2212/review/187196230@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2212@github.com>
References: <quicwg/base-drafts/pull/2212@github.com>
Subject: Re: [quicwg/base-drafts] Proposed change to #1965 (#2212)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1c0c9a3d6b2_3f003fc0686d45bc62689"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6JXGfFSOnbmzQ7gHQRSPEmWsHF0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 21:41:49 -0000
ianswett commented on this pull request. > @@ -496,11 +496,12 @@ MAY use alternate strategies for determining the content of probe packets, including sending new or retransmitted data based on the application's priorities. -If no new data or unacknowledged data is available to send, an ack-eliciting -packet SHOULD be sent. Sending a retransmittable frame ensures that any in -flight packets are acknowledged or declared lost in a timely manner. If no -ack-eliciting packet is sent, any packets currently in flight should be -declared lost to avoid repeatedly arming and firing the PTO timer. +When a PTO timer expires, new or previously-sent data may not be available to +send, and data may still be in flight. A sender can be blocked from sending new ```suggestion send, and packets may still be in flight. A sender can be blocked from sending new ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2212#pullrequestreview-187196230
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- [quicwg/base-drafts] Proposed change to #1965 (#2… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Nick Banks
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… martinduke
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Kazuho Oku
- Re: [quicwg/base-drafts] Proposed change to #1965… MikkelFJ
- Re: [quicwg/base-drafts] Proposed change to #1965… MikkelFJ
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… ianswett
- Re: [quicwg/base-drafts] Proposed change to #1965… janaiyengar
- Re: [quicwg/base-drafts] Proposed change to #1965… Martin Thomson