[quicwg/base-drafts] Current Code for Recovery period misscounts (#1440)
Magnus Westerlund <notifications@github.com> Tue, 12 June 2018 09:25 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E78C13112B for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 02:25:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 14x9j_fxTWAD for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 02:25:08 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC2CA13112A for <quic-issues@ietf.org>; Tue, 12 Jun 2018 02:25:07 -0700 (PDT)
Date: Tue, 12 Jun 2018 02:25:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528795507; bh=QzQfIFkYp7YuE9pD02m082Ih4fCB8yKLXxOJVNXYclo=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=TvFyA1mvFpV+K2eguXJ6Km9AOWVd6KrkXO5a88f0Ac1RgUogGKAKQ0m2E+iQKLx4q 96r/qGoD/2KYbEXAtnBMoBTsnFuobcUdeeJdGYotq2Up3yqXx+IL42hUq3BnONUeK+ giIwUTOcpDHIlFNeiLYc30UOPaC2AT1JunAXEpRk=
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab46caaf6db858012070648715ccb7bf15a6e8c50692cf000000011737537392a169ce13c2665f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1440@github.com>
Subject: [quicwg/base-drafts] Current Code for Recovery period misscounts (#1440)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1f917333b00_594b3facf9754f78526040"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6ML3ptTZl6CqFVWgyB1OMWJqE3g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2018 09:25:11 -0000
Recovery draft:
InRecovery(packet_number):
return packet_number <= end_of_recovery
end_of_recovery = largest_sent_packet
To my understanding the end of recovery will be when one ACKs the packet that is one larger than the largest sent when the congestion event happens. Thus, the InRecovery function should use only < as long as end_of_recovery is not assigned to largest_sent_packet+1 (assuming all PNs are used).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1440
- Re: [quicwg/base-drafts] Current Code for Recover… ianswett
- [quicwg/base-drafts] Current Code for Recovery pe… Magnus Westerlund
- Re: [quicwg/base-drafts] Current Code for Recover… Magnus Westerlund
- Re: [quicwg/base-drafts] Current Code for Recover… Magnus Westerlund