IETF Logo Mail Archive

Re: [quicwg/base-drafts] PADDING counts towards bytes in flight (#1540)

Mike Bishop <notifications@github.com> Mon, 09 July 2018 20:15 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 24786130E6C for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 13:15:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yVQjs9e9HPOl for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 13:15:25 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 82C0C130DE1 for <quic-issues@ietf.org>; Mon, 9 Jul 2018 13:15:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=BiLBwWC3jHJimMed1V4if/pRV3Q=; b=KKTQZHNaW+3/O6hS Ng/rjkT/y1qyMT/WYqFqggX9xImDV8UE8vFzPY3fCRSGR0+YoL9xiOkHqfRHCexd 4XJ0LqPagPvSPc1/MPqjfOsqbX+FUE8UVvGloLJyftXjWjMLTDcNjlFdmmzFcGja mpWryp2nzbG/YMPLrAJltUkJdZI=
Received: by filter0992p1las1.sendgrid.net with SMTP id filter0992p1las1-10404-5B43C25D-F 2018-07-09 20:15:25.242268935 +0000 UTC
Received: from github-lowworker-cbd19a4.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id xZIzO8DnT-Wxs8zZaMKsYQ for <quic-issues@ietf.org>; Mon, 09 Jul 2018 20:15:25.137 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-cbd19a4.cp1-iad.github.net (Postfix) with ESMTP id 14FF1580A32 for <quic-issues@ietf.org>; Mon, 9 Jul 2018 13:15:25 -0700 (PDT)
Date: Mon, 09 Jul 2018 20:15:25 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2da75af2200939e6d39c993504403de41783b28292cf00000001175b845d92a169ce143b9c8b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1540/review/135573985@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1540@github.com>
References: <quicwg/base-drafts/pull/1540@github.com>
Subject: Re: [quicwg/base-drafts] PADDING counts towards bytes in flight (#1540)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b43c25d1201b_138ac3fdfc0096f846775e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2tmFrhc6LM83Flhk160a5Endw+2ii3mlUdTk la3pNCt/ZleVPr+e6/nL5GRxTXxHQVBjf644d8nHIZvf828y8sjC62ECRa2PjX0Xhil0v2R1nRneWe ILth9sNXWQ8j4XOfWcTITNp7jfyIeblfa5Y3Pe0g97iLuv3rMsIH0fSMRUa+SD+wYob9pzAX3zE7IS M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6MsF0HPfGmGKD0oBfxuoWbkkwls>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2018 20:15:28 -0000

MikeBishop commented on this pull request.

I believe "in-flight" should be hyphenated when used as an adjective before the word.

> @@ -110,6 +110,13 @@ important to the loss detection and congestion control machinery below.
 * Retransmittable packets are those that contain at least one retransmittable
   frame.
 
+* PADDING frames do cause packets containing them to count towards bytes in
+  flight, but do not instigate acknowledgement.

Instigate feels like an unusual word choice here.  Not necessarily incorrect, but unusual.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1540#pullrequestreview-135573985

v2.37.1 | Report a Bug | By Email | System Status