Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
martinduke <notifications@github.com> Sun, 21 July 2019 19:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F13FE1200CE for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 12:36:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7riNxw9Laazp for <quic-issues@ietfa.amsl.com>; Sun, 21 Jul 2019 12:36:44 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6BD1D1200B8 for <quic-issues@ietf.org>; Sun, 21 Jul 2019 12:36:44 -0700 (PDT)
Date: Sun, 21 Jul 2019 12:36:43 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563737803; bh=2CvGq6bsmQGYMhFl8gJ1mTdMvAwYKyGkxtb+qHa5Ts0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=A8Hg3Ebz+dR0v5yA2kpN4q18Ok7fWAq74XdMZukaunqsNxuGAM1MGOQkLb/ysFGy/ Ce3jn1cXQALMmWejzcSIr+tW6LyTk38sximyedMsbxlA0AKjqEPL8tIs4EnRb/pPCh fT6Pjao12tVDfbGTlPuMBMDr2/SeeQxX/tRyY5dk=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5ODMBCOAJ6OECXOMV3IHYUXEVBNHHBX66EHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2907/review/264551273@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2907@github.com>
References: <quicwg/base-drafts/pull/2907@github.com>
Subject: Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d34becbaa103_38a93fb6cd6cd964396021"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6a7e9fSYqhJw6K6Phuub3lCdGcU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jul 2019 19:36:46 -0000
martinduke approved this pull request. > @@ -581,13 +581,13 @@ data. If no data can be sent, then the PTO alarm MUST NOT be armed until data has been received from the client. Because the server could be blocked until more packets are received, the client -MUST ensure that the retransmission timer is set if the client does not yet -have 1-RTT keys. If the probe timer expires before the client has 1-RTT keys, -it is possible that the client may not have any crypto data to retransmit. -However, the client MUST send a new packet, containing only PADDING frames if -necessary, to allow the server to continue sending data. If Handshake keys -are available to the client, it MUST send a Handshake packet, and otherwise -it MUST send an Initial packet in a UDP datagram of at least 1200 bytes. +MUST ensure that the retransmission timer is set if the client has not received +an ACK in a Handshake packet or does not yet have 1-RTT keys. If the probe or -> and -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2907#pullrequestreview-264551273
- [quicwg/base-drafts] Fix Recovery Pseudocode (#29… ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … martinduke
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … martinduke
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … martinduke
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Jana Iyengar
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … Martin Thomson
- Re: [quicwg/base-drafts] Fix Recovery Pseudocode … ianswett