IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add max_ack_delay transport parameter and ACK every two packets (#1781)

Christian Huitema <notifications@github.com> Sun, 23 September 2018 22:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B77A130EDC for <quic-issues@ietfa.amsl.com>; Sun, 23 Sep 2018 15:18:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id axy8na8DcY_r for <quic-issues@ietfa.amsl.com>; Sun, 23 Sep 2018 15:18:18 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D1132130ED3 for <quic-issues@ietf.org>; Sun, 23 Sep 2018 15:18:17 -0700 (PDT)
Date: Sun, 23 Sep 2018 15:18:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537741096; bh=cezZRXP00Tlz/GlFGdTybAUXLS5Z0MzlYY99nsUNaGs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VLnJ8Nm4xImkF0mATNu7Ig6vwpgarXpYLyiPW6k9ArVlkYtgDNYygTCF9b1+vjWOR AT+uUT3Hv442vKeFnFvtq2C6SPdW0jId32nDPP/mgBCT11yKJOgflUpMfkVX+X2uVB ZDS1wWCpl/c0CJXAfX3yWHk4/NVK6HkK6oYCu03E=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3e4f88decba355f639bb8d7c903d25b93e857a2692cf0000000117bfd32892a169ce1599ab93@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1781/review/157953859@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1781@github.com>
References: <quicwg/base-drafts/pull/1781@github.com>
Subject: Re: [quicwg/base-drafts] Add max_ack_delay transport parameter and ACK every two packets (#1781)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba81128870de_a063fd258cd45b41641d7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6heK93knZkH9suuyhXe5hiE75cQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Sep 2018 22:18:20 -0000

huitema approved this pull request.

Looks good, follows what we agreed in NYC. Modulo mandatory bike shedding on the description of the parameter.

> @@ -1674,6 +1675,12 @@ disable_migration (0x0009):
   address other than that used to perform the handshake.  This parameter is a
   zero-length value.
 
+max_ack_delay (0x000c):
+
+: An 8 bit unsigned integer value indicating the maximum amount of time in

How about, "the maximum ACK delay in milliseconds"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1781#pullrequestreview-157953859

v2.23.0 | Report a Bug | By Email