Re: [quicwg/base-drafts] Remove the explicit packet number gap in favor of one computed (#496)
Martin Thomson <notifications@github.com> Thu, 04 May 2017 00:11 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 121DF128D6F for <quic-issues@ietfa.amsl.com>; Wed, 3 May 2017 17:11:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.8
X-Spam-Level:
X-Spam-Status: No, score=-4.8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jRmdSca0DgSW for <quic-issues@ietfa.amsl.com>; Wed, 3 May 2017 17:11:46 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6FFF2126CBF for <quic-issues@ietf.org>; Wed, 3 May 2017 17:11:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=QJ+iHm+5C4Zleboc0lUZ3UYm4WU=; b=uGz1W/o98ChA+voV ApJLeWyk3hsgLEg9nrS6nHDLzmE+35t63t5AJ0et+rTmPgJ2FrYVFs7H25McnEqL 1MKsYI0hUWHucCsJKv0X/ETpONwS3zxfDHRwKqyAbgnAfBUe8pnXAQVSnGsT+ehV IJ8rLq7blrFtUZ32hyXrkUQvbvQ=
Received: by filter0660p1mdw1.sendgrid.net with SMTP id filter0660p1mdw1-21314-590A718F-9 2017-05-04 00:10:55.203756401 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id Xdz8xEUsRzeIlZtibQQ5TQ for <quic-issues@ietf.org>; Thu, 04 May 2017 00:10:55.118 +0000 (UTC)
Date: Wed, 03 May 2017 17:10:55 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab213bf67defc9f951c319bc75e498ede801ec2e2992cf000000011522338f92a169ce0d7957f1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/496/review/36168312@github.com>
In-Reply-To: <quicwg/base-drafts/pull/496@github.com>
References: <quicwg/base-drafts/pull/496@github.com>
Subject: Re: [quicwg/base-drafts] Remove the explicit packet number gap in favor of one computed (#496)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_590a718f2b7d_26bc3fd360d55c3c690c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2KfgnnWWEniKhOpGKU0s0VyZI4MxmCKYDCaj XMtmC+m6qIaqgaBlDS0ibNCJtCU1stF5RSAdL4KOPERgIZGXuNcCdqPg9H5SMDP6ST9toQWrSpjZ11 xo291xoMDgpqO1+B+sKGlCpN4XMK8zkm0r2mWvSMa3ecGtgsapV4ydV14/TaomCyl7ZpgKSypc+M7X 8=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6jX0vZdsyu0g2VJF4WxE1SAR2zQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 May 2017 00:11:48 -0000
martinthomson commented on this pull request. > @@ -1296,6 +1291,22 @@ connection ID, it should expect packets on the new connection ID to start at 18. A packet with the new connection ID and a packet number of 17 is discarded as being in error. +#### Packet Number Gap + +In order to avoid linkage, the packet number gap MUST be externally +indistinguishable from random. The packet number gap for a connection +ID with sequence number is computed by encoding the sequence number +as a 32-bit integer in big-endian format, and then computing: + +~~~ +Gap = HKDF-Expand-Label(packet_number_secret, + "QUIC packet sequence gap", sequence, 4) I don't think you want that. The API we agreed on previously was that TLS provides an exporter and the transport uses it. If you want this to be in TLS, then we end up with a much tighter coupling than you would like. (Me, I don't care, I don't see any point in disentangling these two parts, but we did have consensus to separate them.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/496#discussion_r114681126
- [quicwg/base-drafts] Remove the explicit packet n… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson