Re: [quicwg/base-drafts] Permit 0-RTT after Retry and VN (#1514)

janaiyengar <notifications@github.com> Fri, 06 July 2018 23:13 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB98212777C for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 16:13:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mvVVgJSCnu8N for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 16:13:25 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AC750124D68 for <quic-issues@ietf.org>; Fri, 6 Jul 2018 16:13:25 -0700 (PDT)
Date: Fri, 06 Jul 2018 16:13:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530918804; bh=L7D2ygHCF0PpKqAroLbbFpm/mB7UstDBvmtEmwVRgec=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SsYFRUlSbd9ytl3zVUsce22x5PZ/8QT1qzwfGPq7LNAAV8KFV8QTSSMd6a1LN5RKA HZPeoTACGyFCvKjfMsmNfZGYKcm2k890fyOG4FeJvVde6iTc85bvKqXWoMnNN7aKQw VArHtdH2vcjNtXdi6ZuWjTkHklOpS4wImtI+4YsI=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3e3b1d939595b0c76f9b4457c6c0befd1567780c92cf000000011757b99492a169ce1421be50@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1514/review/135179550@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1514@github.com>
References: <quicwg/base-drafts/pull/1514@github.com>
Subject: Re: [quicwg/base-drafts] Permit 0-RTT after Retry and VN (#1514)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3ff794a1a06_624e2ade13b3ef54579e7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6l6qU7ztDTzrRuB20uCEv-DGax0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 23:13:28 -0000

janaiyengar commented on this pull request.



> @@ -770,6 +776,33 @@ are in a different packet number space to other packets (see
 {{packet-numbers}}).
 
 
+### 0-RTT Packet Numbers {#retry-0rtt-pn}
+
+Packet numbers for 0-RTT protected packets use the same space as 1-RTT protected
+packets.
+
+After a client receives a Retry or Version Negotiation packet, 0-RTT packets are
+likely to be lost or discarded by the server, especially if the server changes

s/likely to be/likely to have been/

> @@ -770,6 +776,33 @@ are in a different packet number space to other packets (see
 {{packet-numbers}}).
 
 
+### 0-RTT Packet Numbers {#retry-0rtt-pn}
+
+Packet numbers for 0-RTT protected packets use the same space as 1-RTT protected
+packets.
+
+After a client receives a Retry or Version Negotiation packet, 0-RTT packets are
+likely to be lost or discarded by the server, especially if the server changes
+its connection ID with a Retry packet.  A client MAY attempt to send data in

s/send data/resend data/

> @@ -731,12 +736,13 @@ If the client has a token received in a NEW_TOKEN frame on a previous connection
 to what it believes to be the same server, it can include that value in the
 Token field of its Initial packet.
 
-A client SHOULD NOT reuse a token.  Reusing a token on different network paths
-would allow activity to be linked between paths (see {{migration-linkability}}).
-A client MUST NOT reuse a token if it believes that its point of network
-attachment has changed; that is, if there is a change in its local IP address or
-network interface.  A client needs to start the connection process over if it
-migrates prior to completing the handshake.
+A client SHOULD NOT reuse a token.  Reusing a token could allow different
+connections to be identified as coming from the same endpoint (see also
+{{migration-linkability}}).  A client MUST NOT reuse a token if it believes that
+its point of network attachment has changed since it was last used; that is, if

This seems too strong -- see my comment on the other PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1514#pullrequestreview-135179550