IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add details of marking packets lost on PTO (#2624)

Jana Iyengar <notifications@github.com> Tue, 16 April 2019 02:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4DC2C1202D1 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 19:10:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hwb8oDWxzL5p for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 19:10:20 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 81955120184 for <quic-issues@ietf.org>; Mon, 15 Apr 2019 19:10:20 -0700 (PDT)
Date: Mon, 15 Apr 2019 19:10:19 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555380619; bh=endeo9J9UB4q6N0GJlRKJ/xdbR7+xlgrXLYRoY+QMz4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=egS3HZzs4TiEUAZZOmFsLPTPhwNISQKH3QS30l/Ubikb+/zjDy72y1ezrDBIE/JbD oGarMaAnuoxiwi2FhKH6y63Au7shLFI+W4bzN3M7YGVSNTQOpQR78595hjqs8ifd8b k0djjh4mlSn8qLSItyIQza+R0EIaVANLV8X1ViRE=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2a4824283605d2ee551b339eb156d1fdcb436d7292cebac26c0b92a169ce19d6a975@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2624/review/226957092@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2624@github.com>
References: <quicwg/base-drafts/pull/2624@github.com>
Subject: Re: [quicwg/base-drafts] Add details of marking packets lost on PTO (#2624)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb5398b6b7b1_14e23ff7f60d45c022485e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6o2fIZvdlIe2zwBu67E7NvoSwPc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Apr 2019 02:10:22 -0000

janaiyengar commented on this pull request.



>      pto_count++
+    if (any ack-eliciting frames available to send):
+      SendOneOrTwoPackets()
+    else:
+      // Mark all packets in flight as lost

Why? Because you'd have to mark packets as lost?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2624#discussion_r275607093

v2.23.0 | Report a Bug | By Email