Date: Tue, 12 Nov 2019 06:07:15 -0800
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZ3OVFMSE6JTWCVQ4F327XRHEVBNHHB6EU4CQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3226/review/315556738@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3226@github.com>
References: <quicwg/base-drafts/pull/3226@github.com>
Subject: Re: [quicwg/base-drafts] Clearer text for application errors (#3226)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5dcabc934106c_35f63f87192cd96074589c";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6pmTNyBbhkS5vFgsaO0egpBVITM>


----==_mimepart_5dcabc934106c_35f63f87192cd96074589c
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

mikkelfj commented on this pull request.



> @@ -2720,17 +2720,19 @@ connection in a recoverable state, the endpoint can send a RESET_STREAM frame
 ({{frame-reset-stream}}) with an appropriate error code to terminate just the
 affected stream.
 
-RESET_STREAM MUST be instigated by the protocol using QUIC.  RESET_STREAM
-carries an application error code.  Only the application protocol is able to
+RESET_STREAM MUST be instigated by the application protocol that uses QUIC.

It's more like a transport MUST NOT - surely an application protocol can get through a connection without sending a RESET.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3226#pullrequestreview-315556738
----==_mimepart_5dcabc934106c_35f63f87192cd96074589c
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@mikkelfj</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3226#discussion_r345223273">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -2720,17 +2720,19 @@ connection in a recoverable state, the endpoint can send a RESET_STREAM frame
 ({{frame-reset-stream}}) with an appropriate error code to terminate just the
 affected stream.
 
-RESET_STREAM MUST be instigated by the protocol using QUIC.  RESET_STREAM
-carries an application error code.  Only the application protocol is able to
+RESET_STREAM MUST be instigated by the application protocol that uses QUIC.
</pre>
<p>It's more like a transport MUST NOT - surely an application protocol can get through a connection without sending a RESET.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3226?email_source=notifications&amp;email_token=AFTOJK6FGDKV3T345AELZVLQTK2BHA5CNFSM4JL53632YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHQHAQ#pullrequestreview-315556738">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJKY7BPGRNSB2CL3HTOTQTK2BHANCNFSM4JL5363Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKYBOBBPRD7C7VH3A6TQTK2BHA5CNFSM4JL53632YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHQHAQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3226?email_source=notifications\u0026email_token=AFTOJK6FGDKV3T345AELZVLQTK2BHA5CNFSM4JL53632YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHQHAQ#pullrequestreview-315556738",
"url": "https://github.com/quicwg/base-drafts/pull/3226?email_source=notifications\u0026email_token=AFTOJK6FGDKV3T345AELZVLQTK2BHA5CNFSM4JL53632YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLHQHAQ#pullrequestreview-315556738",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5dcabc934106c_35f63f87192cd96074589c--