[quicwg/base-drafts] 3dc10b: Do not reset pto_count on Initial ACKs

ianswett <noreply@github.com> Sun, 19 April 2020 22:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F1DEB3A03FA for <quic-issues@ietfa.amsl.com>; Sun, 19 Apr 2020 15:08:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.02
X-Spam-Level:
X-Spam-Status: No, score=-1.02 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.82, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c4AjuwhxN3xI for <quic-issues@ietfa.amsl.com>; Sun, 19 Apr 2020 15:08:29 -0700 (PDT)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BB93E3A03F4 for <quic-issues@ietf.org>; Sun, 19 Apr 2020 15:08:29 -0700 (PDT)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id EE1638C0035 for <quic-issues@ietf.org>; Sun, 19 Apr 2020 15:08:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1587334108; bh=tGqpRCrJOkkMbFm5IJ72vI33g6qCu+uwMh+daBpJJhQ=; h=Date:From:To:Subject:From; b=XscHyIitLxZlV6llYoTSojJhmaIIeRankws03ydgOuVWaxixGbFYiDlQOpNc1zi6z dkY75VFSAfWqygk6P2vgXS0MGXMHzhJhehvlPX/tOpYw6UgUOFo+p2h/HAn4ahfedC UDhB73IIVS9aLIN+u54DkXFziS6d43NDJXjG3lhg=
Date: Sun, 19 Apr 2020 15:08:28 -0700
From: ianswett <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/base-drafts/push/refs/heads/master/72c15c-6db743@github.com>
Subject: [quicwg/base-drafts] 3dc10b: Do not reset pto_count on Initial ACKs
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6s670sPrD5dxwBeZjs-YzYuGdbI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Apr 2020 22:08:32 -0000

  Branch: refs/heads/master
  Home:   https://github.com/quicwg/base-drafts
  Commit: 3dc10be1eba2a005b9e95a5f03c5db48951d5464
      https://github.com/quicwg/base-drafts/commit/3dc10be1eba2a005b9e95a5f03c5db48951d5464
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-29 (Sun, 29 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Do not reset pto_count on Initial ACKs

In order to avoid sending anti-deadlock packets too quickly when the server doesn't yet have anything to send.

Fixes #3546


  Commit: 2c682ab830ff4b2d35be0e1a0acc62108ea3d7c9
      https://github.com/quicwg/base-drafts/commit/2c682ab830ff4b2d35be0e1a0acc62108ea3d7c9
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-29 (Sun, 29 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: f31ae49b91f809ec679775f77f565540bda49a7d
      https://github.com/quicwg/base-drafts/commit/f31ae49b91f809ec679775f77f565540bda49a7d
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-29 (Sun, 29 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Revert reflow changes to keep them separate


  Commit: c682269b2ebc0b8d40f97b96e97b69689fd02562
      https://github.com/quicwg/base-drafts/commit/c682269b2ebc0b8d40f97b96e97b69689fd02562
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-29 (Sun, 29 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 50e0259f955a69de2bd7bd88d10ee808a1727432
      https://github.com/quicwg/base-drafts/commit/50e0259f955a69de2bd7bd88d10ee808a1727432
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-29 (Sun, 29 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Set pto_count to 0 when dropping keys

This should have been in the PR that created OnPacketNumberSpaceDiscarded().


  Commit: 85bb93e1be8612c4e1b70a0506e5793b2f966c6e
      https://github.com/quicwg/base-drafts/commit/85bb93e1be8612c4e1b70a0506e5793b2f966c6e
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-30 (Mon, 30 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Only do this for the client


  Commit: 96d2a6bde85df0b92864dd8cdc92b1aa35838dfa
      https://github.com/quicwg/base-drafts/commit/96d2a6bde85df0b92864dd8cdc92b1aa35838dfa
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 62544e2403262f194f0074de29171da839581677
      https://github.com/quicwg/base-drafts/commit/62544e2403262f194f0074de29171da839581677
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Apply suggestions from code review

Co-Authored-By: Martin Thomson <mt@lowentropy.net>


  Commit: 4b278382d1703d6433ae5a1cb2a5ff9628227f27
      https://github.com/quicwg/base-drafts/commit/4b278382d1703d6433ae5a1cb2a5ff9628227f27
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 5a7994cad149f467f72ff21e240c62cfaf0523d8
      https://github.com/quicwg/base-drafts/commit/5a7994cad149f467f72ff21e240c62cfaf0523d8
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-01 (Wed, 01 Apr 2020)

  Changed paths:
    M draft-ietf-quic-http.md
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Merge branch 'master' into ianswett-initial-pto


  Commit: 3bd99fbdbfcc74e15f1a0402f2168b9f30ab14a5
      https://github.com/quicwg/base-drafts/commit/3bd99fbdbfcc74e15f1a0402f2168b9f30ab14a5
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Kazuho's suggestion


  Commit: a1eff954c33c39d35b62d3a5491099e83562f0e2
      https://github.com/quicwg/base-drafts/commit/a1eff954c33c39d35b62d3a5491099e83562f0e2
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Apply suggestions from code review

Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>


  Commit: 53b4584e6fc28ba304486f63e98294ffce326233
      https://github.com/quicwg/base-drafts/commit/53b4584e6fc28ba304486f63e98294ffce326233
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 5226e28d34da20c95106cc8022668b5b09751577
      https://github.com/quicwg/base-drafts/commit/5226e28d34da20c95106cc8022668b5b09751577
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: e701772e6c33bd6002546787c017b54878b392e4
      https://github.com/quicwg/base-drafts/commit/e701772e6c33bd6002546787c017b54878b392e4
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: e192b697af82865eedc302435a35bd99bede506b
      https://github.com/quicwg/base-drafts/commit/e192b697af82865eedc302435a35bd99bede506b
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 02069cd3461402b75d3a6b5924728875ae58277e
      https://github.com/quicwg/base-drafts/commit/02069cd3461402b75d3a6b5924728875ae58277e
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-09 (Thu, 09 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 1a1e49b557c6d913461b4b692aa38884e7aecd1a
      https://github.com/quicwg/base-drafts/commit/1a1e49b557c6d913461b4b692aa38884e7aecd1a
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-18 (Sat, 18 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 7826ec1e1a5db2c03eebd43ff9dfd5ef6b3e4f69
      https://github.com/quicwg/base-drafts/commit/7826ec1e1a5db2c03eebd43ff9dfd5ef6b3e4f69
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-18 (Sat, 18 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 2687b58c43c63eee2bf2f2a229dc95e5b1d05654
      https://github.com/quicwg/base-drafts/commit/2687b58c43c63eee2bf2f2a229dc95e5b1d05654
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-18 (Sat, 18 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: beca7cd89fadd8ab85d81aee9856aa53e90648f9
      https://github.com/quicwg/base-drafts/commit/beca7cd89fadd8ab85d81aee9856aa53e90648f9
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-19 (Sun, 19 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 1f178bd4d73ac7f3f7c2168e775fe5f64c92dc61
      https://github.com/quicwg/base-drafts/commit/1f178bd4d73ac7f3f7c2168e775fe5f64c92dc61
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-19 (Sun, 19 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: eb935271a7446ecdf7d598c794db2ebfd4c4ff39
      https://github.com/quicwg/base-drafts/commit/eb935271a7446ecdf7d598c794db2ebfd4c4ff39
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-19 (Sun, 19 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Update draft-ietf-quic-recovery.md


  Commit: 6db7436f8ed8aaf1d52c1c136321fd3639c08062
      https://github.com/quicwg/base-drafts/commit/6db7436f8ed8aaf1d52c1c136321fd3639c08062
  Author: ianswett <ianswett@users.noreply.github.com>
  Date:   2020-04-19 (Sun, 19 Apr 2020)

  Changed paths:
    M draft-ietf-quic-recovery.md

  Log Message:
  -----------
  Merge pull request #3551 from quicwg/ianswett-initial-pto

Do not reset pto_count on Initial ACKs


Compare: https://github.com/quicwg/base-drafts/compare/72c15c77fefa...6db7436f8ed8