Re: [quicwg/base-drafts] Define abandonment (#2674)

Jana Iyengar <notifications@github.com> Wed, 08 May 2019 00:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E3C8E120183 for <quic-issues@ietfa.amsl.com>; Tue, 7 May 2019 17:22:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.464
X-Spam-Level:
X-Spam-Status: No, score=-1.464 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mMBPyMkReXZk for <quic-issues@ietfa.amsl.com>; Tue, 7 May 2019 17:22:36 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBE25120073 for <quic-issues@ietf.org>; Tue, 7 May 2019 17:22:35 -0700 (PDT)
Date: Tue, 07 May 2019 17:22:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557274955; bh=6VOdxOGCHzeUrxiDhszNuTx+qwoLcfrbo0VsxuZ1Cfs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eNh2gp3Ib24Wo3eETBQUQQod1J5+hsHMyTle+VZNiAIPhBq1slcq0fQ1anuwVfW55 MzKoVmLVmFT2jstcRjAeugriXM2PBDUiIAShv3jeQ6L6pmQdoQ+BmefvVRLfqjua2G U4B00e1g/NAl84Hce486eYH5vFLZ5rGNIZL6QtfQ=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2AVXCXZ52WDDOSURV235J4VEVBNHHBUUFJGM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2674/review/234818617@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2674@github.com>
References: <quicwg/base-drafts/pull/2674@github.com>
Subject: Re: [quicwg/base-drafts] Define abandonment (#2674)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd2214b6d7_8193fb50fccd964112565"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6tTTimN574bbRJ4NQxfVM4dJsnQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 May 2019 00:22:38 -0000

janaiyengar commented on this pull request.



> @@ -1130,6 +1130,8 @@ This system allows a server to process packets with unsupported versions without
 retaining state.  Though either the Initial packet or the Version Negotiation
 packet that is sent in response could be lost, the client will send new packets
 until it successfully receives a response or it abandons the connection attempt.
+As a result, the client discards all state for the connection and does not send
+any more packets.

```suggestion
any more packets on the connection.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2674#pullrequestreview-234818617