IETF Logo Mail Archive

Re: [quicwg/base-drafts] Allow longer CIDs (#2749)

ianswett <notifications@github.com> Tue, 04 June 2019 19:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D599E120619 for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 12:29:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xuMmjpNNWlHy for <quic-issues@ietfa.amsl.com>; Tue, 4 Jun 2019 12:29:43 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E8E7412061B for <quic-issues@ietf.org>; Tue, 4 Jun 2019 12:29:42 -0700 (PDT)
Date: Tue, 04 Jun 2019 12:29:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559676581; bh=r/Oe6mY0Sp/KemxCp2a1RP5VCoRIrQUfZzwJjk+66Fw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=h+FOkXU4rXBTDrOpezPYR9kHYTUQ3UHO+UBbyNhuQtSDyA1YZlra9y1ZCWUrSbSi+ wMPL1KlD3jy6W+J+82bTjdcpyhbPRAITUvE8C8C50zz5rFQf0HYvh51QjQfLLgD66T ZZlqLWz7SJTFlWpLuSrslrq8fajoBhpOX0Q10iaM=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYTCTWX7DU474ZON7V3AP4SLEVBNHHBVJ2RLQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2749/review/245655412@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2749@github.com>
References: <quicwg/base-drafts/pull/2749@github.com>
Subject: Re: [quicwg/base-drafts] Allow longer CIDs (#2749)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf6c6a5bdeda_4a013f9c3f6cd96c137733"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6tuMUc4Vs8R_cN3RhYrGfBonXkc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jun 2019 19:29:56 -0000

ianswett commented on this pull request.



> @@ -1588,15 +1588,15 @@ A token SHOULD be constructed for the server to easily distinguish it from
 tokens that are sent in Retry packets as they are carried in the same field.
 
 The token MUST NOT include information that would allow it to be linked by an
-on-path observer to the connection on which it was issued.  For example, it
+on-path observer to the connection on which it was issued. For example, it

```suggestion
on-path observer to the connection on which it was issued.  For example, it
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2749#pullrequestreview-245655412

v2.23.0 | Report a Bug | By Email