Re: [quicwg/base-drafts] encoder stream can deadlock (#1420)

afrind <notifications@github.com> Mon, 10 September 2018 21:25 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0F0BC130DE1 for <quic-issues@ietfa.amsl.com>; Mon, 10 Sep 2018 14:25:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WaGtC7wicDI4 for <quic-issues@ietfa.amsl.com>; Mon, 10 Sep 2018 14:25:05 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C39D4130DD7 for <quic-issues@ietf.org>; Mon, 10 Sep 2018 14:25:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=CX2eMQ1mhpg6WRZJh+bnz5lK2Dk=; b=o/h8DpwXtRnE9aqz 9hvBM9iKRZCpbPBwsZcQjiIsq+9ec+DMFU4vuIzydpYPU/86Erbe05TXhecCa5Hq UpdOZdTdH2nQn9raOyNbBkKTRO1cV2nFisAtCS1yD5ATlbW7gxCQaf3GT/JGMPUw XP5t9T3xeXEH3tvIZj3OZ9uUwxU=
Received: by filter0658p1las1.sendgrid.net with SMTP id filter0658p1las1-27595-5B96E130-11 2018-09-10 21:25:04.938081861 +0000 UTC m=+344868.963755530
Received: from github-lowworker-cd52d7b.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id OmC4xEG6SWWbAvukkkOuIw for <quic-issues@ietf.org>; Mon, 10 Sep 2018 21:25:04.798 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-cd52d7b.cp1-iad.github.net (Postfix) with ESMTP id C1656920035 for <quic-issues@ietf.org>; Mon, 10 Sep 2018 14:25:04 -0700 (PDT)
Date: Mon, 10 Sep 2018 21:25:05 +0000
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc9e1e03b64483a1a6deee99d485463565298785792cf0000000117aea33092a169ce13a9a7d1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1420/420066409@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1420@github.com>
References: <quicwg/base-drafts/issues/1420@github.com>
Subject: Re: [quicwg/base-drafts] encoder stream can deadlock (#1420)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b96e130c0047_17933fd60ced45b424147b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3GLN7+ld3BzHifxJStY3aYq9JRkt5uYQabjq ikFC30HEOqLX4T8poJgT90MtXMiKV6rxVuzTqFynSXZyJfYUKif2//7w6UzSBL75jzCkiA20EMzQr5 339+/lhHfJIick+Vo4m02AzONE7c3rJchHnQVpSEVPZmRjNdvIfyUkSJpA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/6y_RZJq2RftXZCm-GaGmIolHl9Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Sep 2018 21:25:07 -0000

@MikeBishop and I came up with another encoder stream deadlock.  If an encoder runs out of stream flow control on the encoder stream, it may erroneously send requests (and fill the connection flow control) that depend on bytes that haven't been transmitted.  Some text advising caution in this scenario may be warranted.  eg: perhaps the encoder shouldn't encode a table insert if it would overflow encoder stream flow control window.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1420#issuecomment-420066409