IETF Logo Mail Archive

Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)

Dmitri Tikhonov <notifications@github.com> Tue, 18 September 2018 14:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 73374130E1A for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 07:04:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, T_SPF_HELO_TEMPERROR=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fCtDp2ZyDcry for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 07:04:41 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB8C9130DD2 for <quic-issues@ietf.org>; Tue, 18 Sep 2018 07:04:40 -0700 (PDT)
Date: Tue, 18 Sep 2018 07:04:40 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537279480; bh=HHxTXGhqc/tiHLGJCaJRlw/dHosiuh958IrR9tzQ1k4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Mkvv5s6OZcOOA35nPjNqniotuixBa02ducan0nYELWNzbvK09hZG0VeurfufqVT0W jyLjP450SsTzuMdQmIMjRWzYSq9IcmM7MeO5LnKFlie8K6gjigEacnGdNF32AGwpq/ b1uIQDM4/I3dK7We+Bd3RlyrWvki4fQ6/U58Cj3Q=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5c2eeedc19a536113578ac978e90e88cf5d9c3af92cf0000000117b8c7f892a169ce1586350b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1763/c422405978@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1763@github.com>
References: <quicwg/base-drafts/pull/1763@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba105f835d0f_408a3fc1de4d45c4123659"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/76qbNDu8K_IFmnh7e25wReFjFGk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 14:04:44 -0000

> For example, the size of the ring buffer will be 256 if the header table size is 4,096.

You don't need an array that large, as you can only have 4096 / 32 = 128 entries.  One can do with 128-element ring buffer.

> it could be that the peer decided a non-power of two

That is true.  Nevertheless, I think that we do not need to accommodate systems that cannot perform modulo division.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1763#issuecomment-422405978

v2.30.2 | Report a Bug | By Email | System Status