Re: [quicwg/base-drafts] Update initial congestion window on MTU decrease (#3998)

Martin Thomson <notifications@github.com> Fri, 14 August 2020 01:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBF533A0BE3 for <quic-issues@ietfa.amsl.com>; Thu, 13 Aug 2020 18:50:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dyLdELyevyGl for <quic-issues@ietfa.amsl.com>; Thu, 13 Aug 2020 18:50:08 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 187EB3A0BF1 for <quic-issues@ietf.org>; Thu, 13 Aug 2020 18:50:07 -0700 (PDT)
Received: from github-lowworker-edec459.ac4-iad.github.net (github-lowworker-edec459.ac4-iad.github.net [10.52.18.32]) by smtp.github.com (Postfix) with ESMTP id 466E55C07E2 for <quic-issues@ietf.org>; Thu, 13 Aug 2020 18:50:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597369807; bh=qB+dMju9WDEb8Rcw5Qmtv5xogRdE/4bsA1PcoO5S6Yg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cRAtyMYefST3ccES3E0JNCcpEGP0DWkO3XxMPha5ArfWB8BuX2eIwWNZBbsZap0zQ GSZHlT3BrM2BdWMW04KXYTrlztusFOc9PdmDDZBhlL0j1KTIzBjqDNH9iljPexWqZN IKpkkcS9A9uPaD+/N2DoGTwInW4m5C6qXFo7ptgg=
Date: Thu, 13 Aug 2020 18:50:07 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZP23BCGIHTDUF37GN5IHHM7EVBNHHCQ5DTSU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3998/review/467259199@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3998@github.com>
References: <quicwg/base-drafts/pull/3998@github.com>
Subject: Re: [quicwg/base-drafts] Update initial congestion window on MTU decrease (#3998)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f35edcf2d416_39519641103d2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/79Xvc0QDiJyK65s35Zn5KCeuet4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2020 01:50:09 -0000

@martinthomson commented on this pull request.



> +If the maximum datagram size is decreased in order to complete the handshake,
+the initial congestion window SHOULD be recalculated with the new smaller size.
+This avoids overly large initial congestion windows.  The initial window is
+not recalculated at any other time.

So if we are forced to reset to the initial window after going idle, we can't reset the congestion controller and calculate an initial using the current path MTU?  It seems to me like you might reasonably assume that an MTU is viable for longer than a congestion window.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3998#pullrequestreview-467259199