Re: [quicwg/base-drafts] Fixed handshake key deadlock issue (#3093)
MikkelFJ <notifications@github.com> Tue, 22 October 2019 06:38 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
by ietfa.amsl.com (Postfix) with ESMTP id ABE5D120B0D
for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 23:38:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5
tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546,
HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id HYS12GFlbgqC for <quic-issues@ietfa.amsl.com>;
Mon, 21 Oct 2019 23:38:27 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by ietfa.amsl.com (Postfix) with ESMTPS id 63812120B0C
for <quic-issues@ietf.org>; Mon, 21 Oct 2019 23:38:27 -0700 (PDT)
Date: Mon, 21 Oct 2019 23:38:26 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1571726307;
bh=KNMXSa/X2wJ03yTCCsp0EyO8nP7aUeELZgIXmcmX/e8=;
h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=rkbUKxBhetEQR7S09u2HhY9/dK629Qyii3wOw493vnFxwdJikt01XJMDEGo2kIRYR
hQrCB6VR46uLq4iSNovEmkbEZSPxFg0gKKGAlHqwSqloL8lphNYABmxQ67ZBuV3RVh
ASsk8cW8ezEltwfxvrk6FYyly7iILV3Q+QAstRNw=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts
<reply+AFTOJK425RBMV7RIAPGPTOV3XPSHFEVBNHHB4OJ3YQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3093/c544825620@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3093@github.com>
References: <quicwg/base-drafts/pull/3093@github.com>
Subject: Re: [quicwg/base-drafts] Fixed handshake key deadlock issue (#3093)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5daea3e2b2ee7_792e3ff72b8cd9641224c";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7EnVuXQb2-IP5mYm7eJGVf4WIfg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
<quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
<mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
<mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 06:38:29 -0000
I don't see the problem with an explicit signal. The handshake is uniquely complex already and it helps isolate that complexity. You could even say that if you can drive a handshake to completion within a timeout period, the connection is broken. An explicit signal helps deal with cases where one endpoint otherwise has nothing to send. Now it has. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3093#issuecomment-544825620
- [quicwg/base-drafts] Fixed handshake key deadlock… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… Martin Thomson
- Re: [quicwg/base-drafts] Fixed handshake key dead… Marten Seemann
- Re: [quicwg/base-drafts] Fixed handshake key dead… Kazuho Oku
- Re: [quicwg/base-drafts] Fixed handshake key dead… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… Martin Thomson
- Re: [quicwg/base-drafts] Fixed handshake key dead… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… Marten Seemann
- Re: [quicwg/base-drafts] Fixed handshake key dead… ianswett
- Re: [quicwg/base-drafts] Fixed handshake key dead… Marten Seemann
- Re: [quicwg/base-drafts] Fixed handshake key dead… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… Marten Seemann
- Re: [quicwg/base-drafts] Fixed handshake key dead… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… Martin Thomson
- Re: [quicwg/base-drafts] Fixed handshake key dead… Martin Thomson
- Re: [quicwg/base-drafts] Fixed handshake key dead… ianswett
- Re: [quicwg/base-drafts] Fixed handshake key dead… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… Martin Thomson
- Re: [quicwg/base-drafts] Fixed handshake key dead… martinduke
- Re: [quicwg/base-drafts] Fixed handshake key dead… MikkelFJ