IETF Logo Mail Archive

Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)

ianswett <notifications@github.com> Thu, 30 August 2018 11:03 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A309130E43 for <quic-issues@ietfa.amsl.com>; Thu, 30 Aug 2018 04:03:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OOLduu8jlY0i for <quic-issues@ietfa.amsl.com>; Thu, 30 Aug 2018 04:03:30 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 250C6130E48 for <quic-issues@ietf.org>; Thu, 30 Aug 2018 04:03:30 -0700 (PDT)
Date: Thu, 30 Aug 2018 04:03:27 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535627007; bh=/UR9+/ksBBFPVPJnqlwD+PDODOUY//F61Z4VV/C7UeQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hzQdVOyfV1It1FX3+ufVIRVIdFp8LX/hImWhNHeE6VQWKURo7mRJCz14dH90cxQ2c wg9/4tiIR/AJPdxfYyfRIrbhYxJq704+IV4htu6+a7IRFw5UU58IAXdrR8bg3M0CNR +SrSYJXXndVJFnSsIAM13XZ0myyJe/PQjrbZ8Mp8=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf0c524e67e707c577360a8a7c1ddd864056ccad492cf00000001179f90ff92a169ce152ea636@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1715/review/150942133@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1715@github.com>
References: <quicwg/base-drafts/pull/1715@github.com>
Subject: Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b87ceff710f5_70ef3ffaa36d45c4142877"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7JXjHxhca1h3u-M895s8pu6U7w4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Aug 2018 11:03:32 -0000

ianswett commented on this pull request.



> @@ -3425,6 +3433,10 @@ immediately or when a delayed ack timer expires. The delayed ack timer MUST
 NOT delay an ACK for longer than an RTT, which ensures an ACK frame is sent
 at least once per RTT if new packets needing acknowledgement were received.
 
+If the max_bytes_before_ack transport parameter has been received, the
+receiver SHOULD send an ACK frame immediately once that many octets of packets
+containing frames besides ACK or PADDING have been received.

Yeah, I don't think we want MUST, but I'll add a caveat that if you don't do what the peer requests, you risk reduced performance.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1715#discussion_r213988871

v2.31.3 | Report a Bug | By Email | System Status