IETF Logo Mail Archive

Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)

Matt Olson <notifications@github.com> Wed, 19 June 2019 22:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 34969120134 for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 15:51:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.391
X-Spam-Level:
X-Spam-Status: No, score=-6.391 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CqtUakGAscgb for <quic-issues@ietfa.amsl.com>; Wed, 19 Jun 2019 15:51:02 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A12D21202E7 for <quic-issues@ietf.org>; Wed, 19 Jun 2019 15:51:01 -0700 (PDT)
Date: Wed, 19 Jun 2019 15:51:00 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560984660; bh=uYkwiG9W30u4hh5fR57uIpPPZ88VIfHUb0+8Xf19ni8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HdNs41mB7NAildOJZuktcmJqlhVxZFxqrQxqXDV0GNov6tu8virDAolhQIv86ygi6 9qx1VucJzeMAunpVfgF1BqgyTyucfbeuclCQm0FGilJXQqeQkXCg6IbZydrqJMheVX Cgq8tMFWPc6MQAti5PCieLRqiP7TxuRRIj2A6UhI=
From: Matt Olson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4X46ES274GB6H7DTF3C7XNJEVBNHHBWSJPJ4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2806/review/252009891@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2806@github.com>
References: <quicwg/base-drafts/pull/2806@github.com>
Subject: Re: [quicwg/base-drafts] Merge Crypto timeout and PTO (#2806)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0abc549a2f8_6fbb3f9e4c0cd968134955"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: maolson-msft
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7LBb-RG8F7d6p8K9Tbvm4LV3CxA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Jun 2019 22:51:07 -0000

maolson-msft commented on this pull request.



> @@ -616,6 +553,50 @@ sender might choose to optimize this by setting the timer fewer times if it
 knows that more ack-eliciting packets will be sent within a short period of
 time.
 
+The retransmission timer is not set if the time threshold

```suggestion
The probe timer is not set if the time threshold
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2806#pullrequestreview-252009891

v2.20.0 | Report a Bug | By Email