IETF Logo Mail Archive

Re: [quicwg/base-drafts] Allow longer CIDs (#2749)

Martin Thomson <notifications@github.com> Thu, 13 June 2019 00:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F18B120188 for <quic-issues@ietfa.amsl.com>; Wed, 12 Jun 2019 17:58:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Cx7kgTbqcQjr for <quic-issues@ietfa.amsl.com>; Wed, 12 Jun 2019 17:58:15 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D60CA120276 for <quic-issues@ietf.org>; Wed, 12 Jun 2019 17:58:14 -0700 (PDT)
Date: Wed, 12 Jun 2019 17:58:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560387493; bh=Tuj4gdLR29dnlN/rEqvXz8t9TKiPjMmNoDNYn/rAAYw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DK35kkJv7/R6sV8I8NnPHDEF/j1D8F5UCTMnrNsNXoCw2AAeCRiU7TN22f4zjQdD4 ZhcTbZ/hlSLkIOy6gAmxSRu1XZmRQcuqjmV4X3lUSVPH/5mNTfUE6Ft1Z6Nx7655Bq Nn5A5KQZ1MGWC+Sb8XQjFKLnUNWW1iqy/w1rTdfM=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5HV5JFKAFCT2LBV653B3JCLEVBNHHBVJ2RLQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2749/review/249084524@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2749@github.com>
References: <quicwg/base-drafts/pull/2749@github.com>
Subject: Re: [quicwg/base-drafts] Allow longer CIDs (#2749)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d019fa5b4ace_606a3fd0c86cd968868bc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7OOGzURQXReZeeeNH6FXusliLos>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Jun 2019 00:58:18 -0000

martinthomson approved this pull request.

Thanks for writing this up.  It looks good.

Don't feel that you need to comply with the request below, but if you don't I'll feel obligated to do it myself...

> @@ -143,11 +143,13 @@ version-specific semantics are marked with an X.
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
 |                         Version (32)                          |
 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
-|DCIL(4)|SCIL(4)|
+|    DCIL (8)   |

Maybe not for this PR, but something to consider...

"DCIL" was chosen to fit in the small space available in the diagram.  The new field is a little wider and could fit `DCID Len (8)` comfortably.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2749#pullrequestreview-249084524

v2.23.0 | Report a Bug | By Email