Re: [quicwg/base-drafts] Clarify when a dynamic table entry can be evicted. (#2261)

Bence Béky <notifications@github.com> Fri, 25 January 2019 01:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 65F8112D4E9 for <quic-issues@ietfa.amsl.com>; Thu, 24 Jan 2019 17:07:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.17
X-Spam-Level:
X-Spam-Status: No, score=-10.17 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WK4jpwm-gD75 for <quic-issues@ietfa.amsl.com>; Thu, 24 Jan 2019 17:07:56 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 717D5130F2A for <quic-issues@ietf.org>; Thu, 24 Jan 2019 17:07:56 -0800 (PST)
Date: Thu, 24 Jan 2019 17:07:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548378475; bh=33G4dvA5q3oZgbuCTRdw6/pjaIg7kx3mldNrRKtJBTY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=bLmkmoaHk9Lb2wY3cLNw68Fym8HKM7jOk46tUm2xj7HzSAU54bfYHm8La/WHVhV6L R/UYGJrt9kZ18ZKXmygT8lU7wQAFMHrrLQM8ZxvbU59gNh6clsuIBHQtOjBnS4V297 KWUTO0YiDxyC7sXOG1cAiT+XzYBoUYQQXpmDS96Q=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0ebfc880b53f0f4a537175dbe1df02127de6742592cf000000011862236b92a169ce177f2f28@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2261/review/196322693@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2261@github.com>
References: <quicwg/base-drafts/pull/2261@github.com>
Subject: Re: [quicwg/base-drafts] Clarify when a dynamic table entry can be evicted. (#2261)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4a616bb50f9_35123f8bbd4d45bc6839f7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7PfgM_PVXX4Pm-3Fs6VVHke841s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jan 2019 01:07:58 -0000

bencebeky commented on this pull request.



> @@ -324,10 +332,9 @@ permit the encoder to track the decoder's state.  These events are:
 
 Knowledge that a header block with references to the dynamic table has been
 processed permits the encoder to evict entries to which no unacknowledged
-references remain, regardless of whether those references were potentially
-blocking (see {{blocked-insertion}}).  When a stream is reset or abandoned, the
-indication that these header blocks will never be processed serves a similar
-function; see {{stream-cancellation}}.
+references remain; see {{blocked-insertion}}.  When a stream is reset or

I agree with you.  Sorry, I got inspired by the initial semicolon in this section.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2261#discussion_r250835992