Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

[Nick Banks <[e-mail]>]

nibanks commented on this pull request.



>  
      // Start a new congestion epoch if the last lost packet
      // is past the end of the previous recovery epoch.
-     CongestionEvent(largest_lost_packet.time_sent)
+     CongestionEvent(newest_lost_packet.time_sent)
+
+     // Collapse congestion window if persistent congestion
+     if (InPersistentCongestion(oldest_lost_packet.time_sent)):

Since this only happens in response to an ACK, IF we made any change, I think the change would need to be congestion_time equals the time between the oldest packet lost and the oldest packet acknowledged. That being said, I'm not convinced we really need to make that change. For instance, when comparing to TCP RTO, it's a timer from the oldest packet (or ACK) to Now().

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#discussion_r252444932