IETF Logo Mail Archive

Re: [quicwg/base-drafts] Discard 0-RTT packet state when rejected (#2300)

MikkelFJ <notifications@github.com> Tue, 08 January 2019 16:02 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F8A8130EBE for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 08:02:46 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.064
X-Spam-Level:
X-Spam-Status: No, score=-3.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Bn_4m3VQg_Aw for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 08:02:44 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B6E5130EB0 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 08:02:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=h0eK6hs9Pq4F5vnG9g7tuf3OSJM=; b=o9onmCqqDwOUEqxz WmWWxG00p8fZVXjDlKWZdZexZiQBV8uVBMjJ9+b0dNENTPXUO4UdsCOp4TS7lhBO F3Q6VToqMSpTTYt6kVcOlhVKHakSMIgxiKi6lZCNBM8e/SOt6vx+jZ6hceR8aeNq KMKzTUozLKKtxA12GWzMOPo3gug=
Received: by filter0332p1iad2.sendgrid.net with SMTP id filter0332p1iad2-12472-5C34C9A2-42 2019-01-08 16:02:42.542749958 +0000 UTC m=+44293.466768007
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id e-23lVGRQxWjaj2CVvXRwg for <quic-issues@ietf.org>; Tue, 08 Jan 2019 16:02:42.544 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 805E34403C4 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 08:02:42 -0800 (PST)
Date: Tue, 08 Jan 2019 16:02:42 +0000
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf7ef8f59f82bbc04acf524dea65f26a44092eb9a92cf00000001184c8ba292a169ce179f005f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2300/review/190314666@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2300@github.com>
References: <quicwg/base-drafts/pull/2300@github.com>
Subject: Re: [quicwg/base-drafts] Discard 0-RTT packet state when rejected (#2300)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c34c9a27ec2d_5d083fc163ad45bc8428e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2Ef/mtv5JY9Tw9vltvghG+wF54EWPdK+WOUs GM/3Av2YLvep4pz6rA72KsK8VuNuiFIlr0PwAcWAroM8J1122Is5UruYwDkJxiRjf3qznt0LCRkz5d rpOL9GQD2qNkcspxxjmdkGsNqnRsFGWrcG8nSCUTzW1+Bi++HcUIdMno9bzIEXMQ/Xcx0bVzoIvMig Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7XOz6qO6OD3itfrjZ6EeyeHkb8M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 16:02:46 -0000

mikkelfj commented on this pull request.



> @@ -1001,12 +1001,20 @@ after idle periods, such as those proposed for TCP in {{?RFC7661}}.
 
 ## Discarding Packet Number Space State
 
-When keys for an packet number space are discarded, any packets sent with those
-keys are removed from the count of bytes in flight.  No loss events will occur
-any in-flight packets from that space, as a result of discarding loss recovery
-state (see {{discard-initial}}).  Note that it is expected that keys are
-discarded after those packets would be declared lost, but Initial secrets are
-destroyed earlier.
+When keys for an packet number space are discarded, any in-flight packets

```suggestion
When keys for a packet number space are discarded, any in-flight packets
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2300#pullrequestreview-190314666

v2.23.0 | Report a Bug | By Email