Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)

Mike Bishop <> Mon, 14 October 2019 19:58 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 0BBE4120106 for <>; Mon, 14 Oct 2019 12:58:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id pgruTQcESM8p for <>; Mon, 14 Oct 2019 12:58:31 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 387F012003F for <>; Mon, 14 Oct 2019 12:58:31 -0700 (PDT)
Date: Mon, 14 Oct 2019 12:58:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1571083110; bh=NwIXk34aaqcUFF5BNwtvHA6CrSSeTeyQFXQNqS8ykko=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=F84y0aV1BwYS35wq1zksoQdiy45c8PA/mPA4Y2ph76NwD4/aJsCmgOpNL6EW19S4V Ay4kiH4FtHMuzpjzQ+N2D2IrtoTOuX7A+cRvCS2BEOxkbMprzNvMtsHFdZJJ1BLxYs ZJLzO8Ac+b6k58xTK28Qfj8+oTpCAFSCjWuIEfJk=
From: Mike Bishop <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3089/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da4d36610ca_7d13fb97fccd96835583"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 14 Oct 2019 19:58:33 -0000

MikeBishop commented on this pull request.

> @@ -682,10 +682,10 @@ acknowledged as this instruction does not insert an entry.
 An encoder adds an entry to the dynamic table where the header field name
 matches the header field name of an entry stored in the static or the dynamic
 table using an instruction that starts with the '1' one-bit pattern.  The second
-(`S`) bit indicates whether the reference is to the static or dynamic table. The
+('T') bit indicates whether the reference is to the static or dynamic table. The

I'm fine with it being an index of the tables.  In my mind (thanks in part to HPACK) the static table comes "first," so it feels a little weird that it's 1 vs. 0, but that's probably better than turning something purely editorial into a needless breaking change at this point.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: