Re: [quicwg/base-drafts] loss recovery description mixes variables depending on the packet number space and packet numbers independent of it (#2405)
Marten Seemann <notifications@github.com> Mon, 04 February 2019 07:21 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DD67B1292F1 for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 23:21:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.935
X-Spam-Level:
X-Spam-Status: No, score=-10.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3k2EnmRzk8h1 for <quic-issues@ietfa.amsl.com>; Sun, 3 Feb 2019 23:21:57 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C6ABA126CC7 for <quic-issues@ietf.org>; Sun, 3 Feb 2019 23:21:56 -0800 (PST)
Date: Sun, 03 Feb 2019 23:21:55 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549264915; bh=cpfcvFKFnlBb/Dr/fCl7sDaIGmdfFBMKBEp3rKLCHX4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BWT3MFLTVnehezxm55Azj8sKVHx8W35uI+QvXMYajNzIAVEwUaKy6GY2A7ORCvyzM LjE3dqk7sJ0F2aEt3apB/y3XJ/mmfec0rg23Wg+swEpYCsiuKE5DzT+T7L+2SKOgIv 1fkaGbWf2s7I6ftka0wM+EKZ+SLal/JupgCmjXGo=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1a9b082d1e39bb85810e61d5cebcde8074ca4c3192cf00000001186faa1392a169ce1836223d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2405/460152088@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2405@github.com>
References: <quicwg/base-drafts/issues/2405@github.com>
Subject: Re: [quicwg/base-drafts] loss recovery description mixes variables depending on the packet number space and packet numbers independent of it (#2405)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c57e813ca863_73933fade60d45c03333b7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7YnE3sz3A0NKWZh4y-v0N7J4uqM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2019 07:21:59 -0000
I mostly agree, although there might be some non-editorial parts to it. For example, if `loss_time` is applied per packet number space, we need to define which one to use in `SetLossDetctionTimer()`. I don't see that we do that anywhere (and we don't describe it in the text either). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2405#issuecomment-460152088
- [quicwg/base-drafts] loss recovery description mi… Marten Seemann
- Re: [quicwg/base-drafts] loss recovery descriptio… ianswett
- Re: [quicwg/base-drafts] loss recovery descriptio… Marten Seemann
- Re: [quicwg/base-drafts] loss recovery descriptio… ianswett
- Re: [quicwg/base-drafts] loss recovery descriptio… Jana Iyengar