Re: [quicwg/base-drafts] Try to clarify interaction of PADDING and ACK (#1923)

ianswett <notifications@github.com> Fri, 26 October 2018 13:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2555112896A for <quic-issues@ietfa.amsl.com>; Fri, 26 Oct 2018 06:49:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pPVjLsEbaMVS for <quic-issues@ietfa.amsl.com>; Fri, 26 Oct 2018 06:49:36 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 894BB128A5C for <quic-issues@ietf.org>; Fri, 26 Oct 2018 06:49:36 -0700 (PDT)
Date: Fri, 26 Oct 2018 06:49:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540561775; bh=K+DVr8BuXn64Ii/2oWqZn22tPT/oeCM8WNS4hJwzufc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YIqqtaOBilGd++wSfg6YAX3lulCtDrjzT7pxSGNacmQ+4H2Fa1UFDwuE5aUSNMI3/ h/mOkjsWuTiGb+66HE5dmatNWrsUIBwKcXLbU3nLe3Z4eLD2YUrf5HqjYo/7eAbuNj J8CLBx+CEaHsEocV82HRa53kPh6CkYqennngxlfA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf57ce7266fbdecc28e9120305776098dba7a5ce592cf0000000117eadd6f92a169ce164e9361@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1923/review/168831320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1923@github.com>
References: <quicwg/base-drafts/pull/1923@github.com>
Subject: Re: [quicwg/base-drafts] Try to clarify interaction of PADDING and ACK (#1923)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd31b6fce212_2523fb85a0d45c4141746"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7bPW3SYWJbE_mrJ_yt2kIv8pwOg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Oct 2018 13:49:38 -0000

ianswett commented on this pull request.

Agreed, the current text is awkward, but the idea of eventually acknowledged is both not always true and potentially confusing.

> @@ -2772,13 +2772,13 @@ there are packet gaps which precede the received packet.  The endpoint MUST
 however acknowledge packets containing only ACK or PADDING frames when sending
 ACK frames in response to other packets.
 
-While PADDING frames do not elicit an ACK frame from a receiver, they are
-considered to be in flight for congestion control purposes
-{{QUIC-RECOVERY}}. Sending only PADDING frames might cause the sender to become
-limited by the congestion controller (as described in {{QUIC-RECOVERY}}) with no
-acknowledgments forthcoming from the receiver. Therefore, a sender should ensure
-that other frames are sent in addition to PADDING frames to elicit
-acknowledgments from the receiver.
+While PADDING frames are only eventually acknowledged, they are still considered

```suggestion
While PADDING frames may never be acknowledged, they are still considered
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1923#pullrequestreview-168831320