[quicwg/base-drafts] Allow CRYPTO_BUFFER_EXCEEEDED error when CRYPTO frame goes beyond 2^62 bytes (#3258)

Kazuho Oku <notifications@github.com> Mon, 18 November 2019 07:58 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DEE871208E8 for <quic-issues@ietfa.amsl.com>; Sun, 17 Nov 2019 23:58:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id G_mZfFOdWroa for <quic-issues@ietfa.amsl.com>; Sun, 17 Nov 2019 23:58:58 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B5AD1200B2 for <quic-issues@ietf.org>; Sun, 17 Nov 2019 23:58:58 -0800 (PST)
Date: Sun, 17 Nov 2019 23:58:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574063937; bh=IO6hU932v2BjTltbTORmmgvmqZbQaANN1w5LZVRqKVw=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=dqhuS3mBEN2E9T+TnoXTn6udWBvtlw3ga1eGJyjA5lgtgUucB9yzXdAftdfpnfY8/ y0QPC6XLtSnJy7pPDnMw37dymGJ8ijnC0RUgYewLE4X5gNlQ4Sz86tXc1FQR9lXwep od2dCGUfTlnfollPkQ59y/6nULr92Wu3dKR75NJg=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZWQ3VL5WED6O35BF5336A4DEVBNHHB6PVAQQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3258@github.com>
Subject: [quicwg/base-drafts] Allow CRYPTO_BUFFER_EXCEEEDED error when CRYPTO frame goes beyond 2^62 bytes (#3258)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd24f41645b7_6de03fd4410cd9603203d3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7iQsOtqLFKFW8Pd4rQGXin1oRxM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2019 07:59:00 -0000


When discussing #3027 at Cupertino, we agreed that either of the following two errors can be sent when the payload of the STREAM frame exceeds 2^62 bytes:
* FRAME_ENCODING_ERROR
* FLOW_CONTROL_ERROR

And we've merged PR #3042 that made that change, along with other changes. However, in that PR, we failed to apply the rule that we agreed for SRTEAM frame to CRYPTO frame.

Editors' draft now allows use of FRAME_ENCODING_ERROR for CRYPTO frames, but not CRYPTO_BUFFER_EXCEEDED.

As CRYPTO_BUFFER_EXCEEDED *is* the flow control error for CRYPTO streams, that should be permitted too.

To be fixed by PR #3186.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3258