Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)

Lucas Pardue <> Fri, 11 October 2019 10:10 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id DD365120058 for <>; Fri, 11 Oct 2019 03:10:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id I35rUAhffSle for <>; Fri, 11 Oct 2019 03:10:58 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 421DA120033 for <>; Fri, 11 Oct 2019 03:10:58 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id 710C7660DBB for <>; Fri, 11 Oct 2019 03:10:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1570788657; bh=75qdVs9XG3/0DL1yP4dEIIBb4qPnGbnZjAct6mVFp1E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=cJoOG+1S2qywqD24xxh3y9GGrXvQFd6yWwrUONDGvgmTvU2u64FmC3ml/5f9iLXHh 6G/LYCA/CvligMMdq6nUtOlkulevDkCrPfttKixL6trVCZOhdAnSJkQHJIzJZGvZRI 8EGlhR9LoyaizYb2Tk7TDf5Ur8pkYAvEXuDIwoNs=
Date: Fri, 11 Oct 2019 03:10:57 -0700
From: Lucas Pardue <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3083/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Additional error cases for CANCEL_PUSH (#3083)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da055316214c_2cb43fa9b92cd95c31272a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 11 Oct 2019 10:11:00 -0000

LPardue commented on this pull request.

> @@ -1093,10 +1094,15 @@ error of type HTTP_FRAME_UNEXPECTED.
 The CANCEL_PUSH frame carries a Push ID encoded as a variable-length integer.
 The Push ID identifies the server push that is being cancelled (see
+{{frame-push-promise}}).  If a CANCEL_PUSH frame is received which references a
+Push ID greater than currently allowed on the connection, this MUST be treated

I think there are two effective limits - the maximum allowed push ID and the maximum used push ID. So if I understand Ian's point, there is not a situation where a client can issue a CANCEL_PUSH that violates the maximum allowed push ID without first triggering the violation of the maximum used push ID.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: