Re: [quicwg/base-drafts] Fix for #3835 (#4014)
Martin Thomson <notifications@github.com> Thu, 20 August 2020 00:28 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8F523A0FBE for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 17:28:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J_TUF4pyrzwd for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 17:28:43 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7C6883A0FBD for <quic-issues@ietf.org>; Wed, 19 Aug 2020 17:28:43 -0700 (PDT)
Received: from github-lowworker-c73936b.ash1-iad.github.net (github-lowworker-c73936b.ash1-iad.github.net [10.56.112.13]) by smtp.github.com (Postfix) with ESMTP id A32B65C059C for <quic-issues@ietf.org>; Wed, 19 Aug 2020 17:28:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597883322; bh=RERq2tFzF94ZYCapKju3klTCJubiQX072Iw0+Nms/EA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XgWlxZd1fp/M0n5p9hk2B5HNbNaWsYJy/HYnF8rKXOWCOmf6wGLYTO/9H8HhspNMT FCUQ3hY7WJTuKrR6uesa8y84EyPhfyc/04msbwjpHDT05iT09TMxIIlDqjMTiiYZMW /BvL7XZiwK3Y+FuPw20qKF8VQeKOk0556GLtTFvI=
Date: Wed, 19 Aug 2020 17:28:42 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6R5GOQSWWL5XTV2FV5JGSLVEVBNHHCRI7QOY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4014/review/471049698@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4014@github.com>
References: <quicwg/base-drafts/pull/4014@github.com>
Subject: Re: [quicwg/base-drafts] Fix for #3835 (#4014)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3dc3ba8dff2_7f41196445911"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7jxg1O0_OwBOKcN5D9ajvOPL5Wc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 00:28:45 -0000
@martinthomson requested changes on this pull request. I didn't want to do this. I believe that more now that I've seen this. These are both wrong, which demonstrates how this is non-trivial. That's why this was originally limited to transitions. > + | Recv STREAM / STREAM_DATA_BLOCKED / RESET_STREAM + | Create Bidirectional Stream (Sending) + | Recv MAX_STREAM_DATA / STOP_SENDING (Bidirectional) + | Create Higher-Numbered Stream + v + +-------+ + | Recv | Recv RESET_STREAM + +->| |-----------------------. +Recv | +-------+ | +STREAM | | | | + +----+ | Recv STREAM + FIN | + v | + +-------+ | + | Size | Recv RESET_STREAM | + | Known |---------------------->| + +-------+ | You receive STREAM frames here as well. > + +->| |-----------------------. +Recv | +-------+ | +STREAM | | | | + +----+ | Recv STREAM + FIN | + v | + +-------+ | + | Size | Recv RESET_STREAM | + | Known |---------------------->| + +-------+ | + | | + | Recv All Data | + v v + +-------+ Recv RESET_STREAM +-------+ + | Data |--- (optional) --->| Reset | + | Recvd | Recv All Data | Recvd | + +-------+<-- (optional) ----+-------+ And here, in case of reordering or spurious retransmission. > + | STREAM_DATA_BLOCKED | + | | + | Peer Creates | + | Bidirectional Stream | + v | + +-------+ | + | Send | Send RESET_STREAM | + +-->| |---------------------->| +Send | +-------+ | +STREAM | | | | + +-----+ | Send STREAM + FIN | + v v + +-------+ +-------+ + | Data | Send RESET_STREAM | Reset | + | Sent |------------------>| Sent | + +-------+ +-------+ You send STREAM frames here too when packets get declared lost. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/4014#pullrequestreview-471049698
- [quicwg/base-drafts] Fix for #3835 (#4014) Lars Eggert
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) Mike Bishop
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) Jana Iyengar
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) ianswett
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) Martin Thomson
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) Jana Iyengar
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) Lars Eggert
- Re: [quicwg/base-drafts] Fix for #3835 (#4014) Martin Thomson