Re: [quicwg/base-drafts] Separate key/secret availability from usage (#1654)

Mike Bishop <notifications@github.com> Tue, 14 August 2018 15:50 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 880C0130E0A for <quic-issues@ietfa.amsl.com>; Tue, 14 Aug 2018 08:50:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gx35X1Z7qZ1j for <quic-issues@ietfa.amsl.com>; Tue, 14 Aug 2018 08:50:44 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 29687130DC8 for <quic-issues@ietf.org>; Tue, 14 Aug 2018 08:50:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=mUNPsbdsPk3G+zYLPP5U8Xo+5yY=; b=wUHaRgvjtdwazPRh VNNvNgZqaHi5AQ2I4GCaaUsQPzfzi0HGftqYBd6UUqNuqoupxl2Fm4XxlSrfopSY 6l3hRGKjaZN+wGCIoc2x5g52EHz8OQon7aDyKvIl9warRv3YAe9/NRDUkmb+qTcs uJDvRYrrI1nposJDQTjkWhTAivE=
Received: by filter0725p1las1.sendgrid.net with SMTP id filter0725p1las1-13015-5B72FA52-1C 2018-08-14 15:50:42.656469992 +0000 UTC m=+57727.686616699
Received: from github-lowworker7-cp1-prd.iad.github.net (unknown [192.30.252.47]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id drpa79YKQKKOVyTefOyzmQ for <quic-issues@ietf.org>; Tue, 14 Aug 2018 15:50:42.599 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker7-cp1-prd.iad.github.net (Postfix) with ESMTP id 92266A2B02 for <quic-issues@ietf.org>; Tue, 14 Aug 2018 08:50:42 -0700 (PDT)
Date: Tue, 14 Aug 2018 15:50:43 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe4e6cd4b26d597880b228226d5b1d9d3627e5fa392cf00000001178abc5292a169ce14db09b1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1654/review/146131206@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1654@github.com>
References: <quicwg/base-drafts/pull/1654@github.com>
Subject: Re: [quicwg/base-drafts] Separate key/secret availability from usage (#1654)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b72fa529042b_5f443fe3f60be61c2323b1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1KVWSavIEFELid338m8H1MnFVTnDllP8a905 ytjIXwzHHOzN6+HARadlPpctclPrXpwpWZ+4jgaavg3tRo6i5G68r8kA0bVe/83tv5j3abRL5fjv0s p+ZYCiSJQEIVRqrXDcgxdFSBxCUctHxrgjuheQhjlTusKPOz7z4wxvFB/c9cx0yXLy64mjFou3bmyB Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7lVfOfJvgOr5z1QeABdm-9uMzYA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Aug 2018 15:50:46 -0000

MikeBishop commented on this pull request.



> @@ -457,7 +457,11 @@ Although TLS only uses one encryption level at a time, QUIC may use more than
 one level. For instance, after sending its Finished message (using a CRYPTO
 frame at the Handshake encryption level) an endpoint can send STREAM data (in
 1-RTT encryption). If the Finished message is lost, the endpoint uses the
-Handshake encryption level to retransmit the lost message.
+Handshake encryption level to retransmit the lost message.  Reordering or loss
+of packets can mean that QUIC will need to handle packets at multiple encryption
+levels.  During the handshake, this means potentially handling of packets at

"potentially handling packets" or "handling of packets", but not both.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1654#pullrequestreview-146131206