Re: [quicwg/base-drafts] Discard Initial keys as soon as possible (#2045)
Christian Huitema <notifications@github.com> Mon, 26 November 2018 05:25 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C34AD128CB7 for <quic-issues@ietfa.amsl.com>; Sun, 25 Nov 2018 21:25:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0nbcK_MiRFSc for <quic-issues@ietfa.amsl.com>; Sun, 25 Nov 2018 21:25:00 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6EF351271FF for <quic-issues@ietf.org>; Sun, 25 Nov 2018 21:25:00 -0800 (PST)
Date: Sun, 25 Nov 2018 21:24:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543209899; bh=mOAibMQYePwctQj2SoZwrrp7lpZljSs6rkZc3XIxZD0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JSTIrSps9DvUvejyx41v+tOlpe0WPclQ9sU6eqRe+1DkgAP7xQh0g9eoHTrAB35n9 5aOYfYLXNlu9vqGtH7FaQDtVIRouk7R2nxjUjHwXC4DiEW9ybdVPpOVDXMyFpqU3zi PKK8Y4ajHr0ReelKKFgNJuMt5dwtD35cMs6kSBHQ=
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc03fc6f28278f2eef345f16dd8f6c83f59ef9a0f92cf00000001181345ab92a169ce16de7e61@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2045/review/178136965@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2045@github.com>
References: <quicwg/base-drafts/pull/2045@github.com>
Subject: Re: [quicwg/base-drafts] Discard Initial keys as soon as possible (#2045)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bfb83ab52717_5543f942f2d45bc79341"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: huitema
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7pypACxthMzvTGaSAUwwT2JiaoM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Nov 2018 05:25:02 -0000
huitema commented on this pull request. > @@ -1059,6 +1083,14 @@ A sender that does not use pacing SHOULD reset its congestion window to the minimum of the current congestion window and the initial congestion window. This recommendation is based on Section 4.1 of {{?RFC5681}}. +## In-Flight Packet Accounting + +When keys for an encryption level are discarded (see {{QUIC-TLS}}), any packets +sent with those keys are removed from the count of bytes in flight. No loss +events will occur for these packets. Note that it is expected that keys are +discarded after those packets would be declared lost, but Initial secrets are +destroyed earlier. We discussed some of that in the chat room (because we enjoy splitting discussions on many channels with different note well rules). The general idea is that if packets are implicitly acknowledged, then the corresponding bytes are removed from the count of bytes in flight. To quote, "_Implicit ACK should be treated just like regular ACK, but there are 2 small issues -- spurious repeat, and ACK. The handshake can complete with a spurious repeat still in flight, or with a not-yet-received ACK. Still, that cannot be a huge deal._" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2045#discussion_r236125398
- [quicwg/base-drafts] Discard Initial keys as soon… Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Marten Seemann
- Re: [quicwg/base-drafts] Discard Initial keys as … ekr
- Re: [quicwg/base-drafts] Discard Initial keys as … Marten Seemann
- Re: [quicwg/base-drafts] Discard Initial keys as … ekr
- Re: [quicwg/base-drafts] Discard Initial keys as … Rui Paulo
- Re: [quicwg/base-drafts] Discard Initial keys as … Marten Seemann
- Re: [quicwg/base-drafts] Discard Initial keys as … Rui Paulo
- Re: [quicwg/base-drafts] Discard Initial keys as … MikkelFJ
- Re: [quicwg/base-drafts] Discard Initial keys as … Rui Paulo
- Re: [quicwg/base-drafts] Discard Initial keys as … MikkelFJ
- Re: [quicwg/base-drafts] Discard Initial keys as … Kazuho Oku
- Re: [quicwg/base-drafts] Discard Initial keys as … Christian Huitema
- Re: [quicwg/base-drafts] Discard Initial keys as … Christian Huitema
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … Christian Huitema
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … Christian Huitema
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Christian Huitema
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … Mike Bishop
- Re: [quicwg/base-drafts] Discard Initial keys as … janaiyengar
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Mike Bishop
- Re: [quicwg/base-drafts] Discard Initial keys as … janaiyengar
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … janaiyengar
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … ekr
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … ekr
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … ianswett
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Christian Huitema
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson
- Re: [quicwg/base-drafts] Discard Initial keys as … Martin Thomson