Re: [quicwg/base-drafts] Omit already acknowledged ACK Blocks (#2245)
MikkelFJ <notifications@github.com> Fri, 21 December 2018 22:36 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 82593130E9F for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 14:36:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AvFTC_Bt45kk for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 14:36:56 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F4C0130E9C for <quic-issues@ietf.org>; Fri, 21 Dec 2018 14:36:56 -0800 (PST)
Date: Fri, 21 Dec 2018 14:36:54 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545431814; bh=MfpMrTBoWGX/kgFc7L88g85LtJ4I96pkIaRd56s2x4A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dctYpe+Xbsp083mcEYijQkAd4U9CPgJos5otaPDt/IlMvZ6cIe9wbZwLBzQNdqIke DgpCgC72HcqbYUIiqALQgHF6us0ZRI6TzPv+4eMwb9gRxnoGFHQkH7azZjgquIUE+9 GitStBATHu7CiAjAkfr/yqIVVtRMHXfXpYbqAltU=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc7639f5a09cf8807c6cb7722f93ffbf223b4253c92cf0000000118352d0692a169ce1775e62e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2245/review/187557022@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2245@github.com>
References: <quicwg/base-drafts/pull/2245@github.com>
Subject: Re: [quicwg/base-drafts] Omit already acknowledged ACK Blocks (#2245)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d6b06961c4_47283feda50d45bc6602f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7tzxinN-ff9jAsUXdUSdIOQkhiQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 22:36:58 -0000
mikkelfj commented on this pull request.
> @@ -2858,8 +2858,8 @@ discussed in more detail in {{QUIC-RECOVERY}}.
To limit ACK Blocks to those that have not yet been received by the sender, the
receiver SHOULD track which ACK frames have been acknowledged by its peer. Once
-an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be
-acknowledged again.
+an ACK frame has been acknowledged, an endpoint SHOULD omit all ACK Blocks that
+have not changed since the ACK frame was sent from future ACK frames.
Cant this be reworded somehow? I think I know what it means, but I don't understand the text.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2245#pullrequestreview-187557022
- Re: [quicwg/base-drafts] Omit already acknowledge… Kazuho Oku
- Re: [quicwg/base-drafts] Omit already acknowledge… MikkelFJ
- [quicwg/base-drafts] Omit already acknowledged AC… ianswett
- Re: [quicwg/base-drafts] Omit already acknowledge… MikkelFJ
- Re: [quicwg/base-drafts] Omit already acknowledge… ianswett
- Re: [quicwg/base-drafts] Omit already acknowledge… ianswett
- Re: [quicwg/base-drafts] Omit already acknowledge… Kazuho Oku
- Re: [quicwg/base-drafts] Omit already acknowledge… ianswett
- Re: [quicwg/base-drafts] Omit already acknowledge… ianswett
- Re: [quicwg/base-drafts] Omit already acknowledge… MikkelFJ
- Re: [quicwg/base-drafts] Omit already acknowledge… MikkelFJ
- Re: [quicwg/base-drafts] Omit already acknowledge… Martin Thomson
- Re: [quicwg/base-drafts] Omit already acknowledge… Martin Thomson