Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)

ianswett <notifications@github.com> Tue, 18 August 2020 14:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CD6553A0BB6 for <quic-issues@ietfa.amsl.com>; Tue, 18 Aug 2020 07:49:55 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QF5NWOrAA6gp for <quic-issues@ietfa.amsl.com>; Tue, 18 Aug 2020 07:49:54 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 61F013A0BB1 for <quic-issues@ietf.org>; Tue, 18 Aug 2020 07:49:54 -0700 (PDT)
Received: from github-lowworker-1ac52d7.ash1-iad.github.net (github-lowworker-1ac52d7.ash1-iad.github.net [10.56.25.52]) by smtp.github.com (Postfix) with ESMTP id B3F11560094 for <quic-issues@ietf.org>; Tue, 18 Aug 2020 07:49:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597762193; bh=lZTFN8Ntz1j4ShXjmE2CNWNgCXVYRggvzqAC0WPXAag=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mLbxcmrXMDPsH5r2hE4KY3OEcW8jN1n5C+tmExyhGpAbGu5ps/ULrxUHspmQ/T4qv n4BAZVoshJOqN/IqEBX4McRcQpNp/3gR6oTf0Z1U6v1ZB01pcm2STlDsaxK4kdbfIv sN2fdlseg3ZOvBiILVzVqmIW6i2C+vKbHa77RMMQ=
Date: Tue, 18 Aug 2020 07:49:53 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5O3A5AL66FJVOGHL55I7FZDEVBNHHCRBYB7A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4005/review/469531925@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4005@github.com>
References: <quicwg/base-drafts/pull/4005@github.com>
Subject: Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3bea91a3044_174e196414886a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/7zGYAsAuaABKZvIi8e3pMDlrXao>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Aug 2020 14:49:56 -0000

@ianswett approved this pull request.

LG, one suggestion on ssthresh init.

> @@ -763,24 +763,33 @@ The RECOMMENDED value is 2 * max_datagram_size.
 
 ## Slow Start
 
-While in slow start, QUIC increases the congestion window by the
-number of bytes acknowledged when each acknowledgment is processed, resulting
-in exponential growth of the congestion window.
+The congestion controller is in slow start any time the congestion window is
+below the slow start threshold.  The congestion controller begins in slow start.

+1 to this suggestion, since I had the same thought.  ssthresh is initialized to infinity, which is in the pseudocode, but not in this text I'm now noticing.
```suggestion
below the slow start threshold.  The congestion controller begins in slow start
because the slow start threshold is initialized to an infinite value.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4005#pullrequestreview-469531925