Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)

Kazuho Oku <notifications@github.com> Wed, 27 May 2020 06:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E16A3A080B for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 23:02:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1MuIxALYFzpD for <quic-issues@ietfa.amsl.com>; Tue, 26 May 2020 23:02:11 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 38DCC3A0808 for <quic-issues@ietf.org>; Tue, 26 May 2020 23:02:11 -0700 (PDT)
Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id AEF58120350 for <quic-issues@ietf.org>; Tue, 26 May 2020 23:02:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590559330; bh=aX44Xa4qeDTdwJsCU/qv22ZCqLQn9VWICmGDewf8Q7Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=t3MaZjZsmqfrGQBQ2Ae1K3IqxRAWP0fsAakKD0voJ3N1+BrnISIlc4kfwJsnA63ic 0kCBIKyQ/HpHr8gxESQeZiEURv4Zz9vpZmK0nlrFEGS/QUodfuMykd35lzNIGvi9Xs lCk35vwOtP0qnYK/KWB/RL4YnMbNppmXU5kkOJkY=
Date: Tue, 26 May 2020 23:02:10 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ4IRYRDM2OPPY5FE543HRWFEVBNHHCKLSLMI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3691/review/418878529@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3691@github.com>
References: <quicwg/base-drafts/pull/3691@github.com>
Subject: Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ece026269305_4ee43ff1042cd960929349"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/88GhDR4-3Cf2_KkKFDGDTnVyLKM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2020 06:02:13 -0000

@kazuho commented on this pull request.



>  
-* absence of the original_destination_connection_id transport parameter from
-  the server,
+An endpoint MUST treat the following as a connection error of type
+PROTOCOL_VIOLATION:
 
 * absence of the retry_source_connection_id transport parameter from the server
   after receiving a Retry packet,

The simplest change would be to move these two cases that deal with `retry_source_connection_id` above, so that they would be classified as TRANSPORT_PARAMETER_ERROR. Doing so does not forbid endpoints from sending PROTOCOL_VIOLATION, as we have a catch-all clause stating that sending PROTOCOL_VIOLATION in place of other error code is permitted.

If want to be verbose, we could say that _An endpoint MUST treat the following as a connection error of type PROTOCOL_VIOLATION or TRANSPORT_PARAMETER_ERROR: (list the two bullet points covering `retry_source_connection_id`)_.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3691#discussion_r430875128