Re: [quicwg/base-drafts] Single Packet Number Space (#1591)
Mike Bishop <notifications@github.com> Tue, 07 August 2018 16:52 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7BDB81310B9 for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 09:52:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uDCOk9LeStHB for <quic-issues@ietfa.amsl.com>; Tue, 7 Aug 2018 09:52:50 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1E49E13106D for <quic-issues@ietf.org>; Tue, 7 Aug 2018 09:52:50 -0700 (PDT)
Date: Tue, 07 Aug 2018 09:52:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533660769; bh=9l86rU5OtdTeM12rDH3MnqEDcirUG4KK7ukpnIy9mIM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zWA6F/tBoLp7Oidys0TcDLyOfEts453gA/mjaWOHu+ABT/NYBUwvtTJGp5ImtGedt Jeh01+RMwHwYztcf23WTrGYXA38Nf18sD75w3wLIiukODR6QF5KFk9F9YfCVRMp8EX R+b2kHWh/fDZ0cMYO1+i2e9v68woWAqmFSXZ47sc=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe320b194fde64eb30f7dcb94e364927bf43ed9b992cf000000011781906192a169ce1473dec6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1591/review/144088858@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1591@github.com>
References: <quicwg/base-drafts/pull/1591@github.com>
Subject: Re: [quicwg/base-drafts] Single Packet Number Space (#1591)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b69ce611e385_280b3f93ea4be624731e6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8ETFWnGLpuBU1wEF8MpV2doX8WQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Aug 2018 16:52:59 -0000
MikeBishop commented on this pull request.
> @@ -118,10 +118,8 @@ Retransmittable Packets:
All transmissions in QUIC are sent with a packet-level header, which indicates
the encryption level and includes a packet sequence number (referred to below as
-a packet number). The encryption level indicates the packet number space, as
-described in {{QUIC-TRANSPORT}}. Packet numbers never repeat within a packet
-number space for the lifetime of a connection. Packet numbers monotonically
-increase within a space, preventing ambiguity.
+a packet number). Packet numbers never repeat for the lifetime of a connection.
+Packet numbers monotonically increase within a space, preventing ambiguity.
But you have no packet number spaces here.... I'm guessing this is a merge artifact.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1591#pullrequestreview-144088858
- Re: [quicwg/base-drafts] Single Packet Number Spa… Nick Banks
- Re: [quicwg/base-drafts] Single Packet Number Spa… Nick Banks
- [quicwg/base-drafts] Single Packet Number Space (… Nick Banks
- Re: [quicwg/base-drafts] Single Packet Number Spa… Nick Banks
- Re: [quicwg/base-drafts] Single Packet Number Spa… Christian Huitema
- Re: [quicwg/base-drafts] Single Packet Number Spa… Nick Banks
- Re: [quicwg/base-drafts] Single Packet Number Spa… Nick Banks
- Re: [quicwg/base-drafts] Single Packet Number Spa… Mike Bishop
- Re: [quicwg/base-drafts] Single Packet Number Spa… Mike Bishop
- Re: [quicwg/base-drafts] Single Packet Number Spa… Nick Banks
- Re: [quicwg/base-drafts] Single Packet Number Spa… Mike Bishop
- Re: [quicwg/base-drafts] Single Packet Number Spa… Martin Thomson
- Re: [quicwg/base-drafts] Single Packet Number Spa… Martin Thomson