Re: [quicwg/base-drafts] Add handling of all packets marked as CE (#3455)

Martin Thomson <notifications@github.com> Thu, 13 February 2020 23:55 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AA086120026 for <quic-issues@ietfa.amsl.com>; Thu, 13 Feb 2020 15:55:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e3b3-tdL6lA0 for <quic-issues@ietfa.amsl.com>; Thu, 13 Feb 2020 15:55:54 -0800 (PST)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 91B21120020 for <quic-issues@ietf.org>; Thu, 13 Feb 2020 15:55:54 -0800 (PST)
Date: Thu, 13 Feb 2020 15:55:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581638154; bh=nc9ZX/KwA1h3Fq/Vt6aqZwiAaOyw9imT5tQMquKhmAc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ztEVtc7wDXiqw1znLYawAXFgmnIhhIhqtQtJsO2skLJwW5aAfVd70lvgq5whjh3A5 72WkFyDGbbnvudQh8QMznd5zgzdWHsEq2+qXyPma9lkhn/3k81CEuj0PAMUpqDXoxn jJ2kIBXijEdoiw8G1pGbCAyPtmldk7SJUsoCcNLA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7NCR4CPS2IPYR74XF4KMKITEVBNHHCDKLF64@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3455/review/358633335@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3455@github.com>
References: <quicwg/base-drafts/pull/3455@github.com>
Subject: Re: [quicwg/base-drafts] Add handling of all packets marked as CE (#3455)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e45e209f200a_258d3f9231ecd9681242a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8LgtQ0eImImxmf3vHlfOi3uz9PI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Feb 2020 23:55:57 -0000

martinthomson commented on this pull request.

Thanks for doing this.  

This is a design change and needs a corresponding issue.

A few typos and suggestions below.

> @@ -3517,6 +3517,13 @@ use the following steps on receiving an ACK frame to validate ECN.
   corresponding ECT codepoint that are newly acknowledged in this ACK frame.
   This step detects any erroneous network remarking from ECT(0) to ECT(1) (or
   vice versa).
+  
+Another special case is when all packets are indicatd as CE marked,

```suggestion
Another special case is when all packets are marked ECN-CE,
```

> @@ -3517,6 +3517,13 @@ use the following steps on receiving an ACK frame to validate ECN.
   corresponding ECT codepoint that are newly acknowledged in this ACK frame.
   This step detects any erroneous network remarking from ECT(0) to ECT(1) (or
   vice versa).
+  
+Another special case is when all packets are indicatd as CE marked,
+independtly of the initial codepode used, including Not-ECT. In this case

```suggestion
independent of the marking used, including Not-ECT. In this case
```

> @@ -3517,6 +3517,13 @@ use the following steps on receiving an ACK frame to validate ECN.
   corresponding ECT codepoint that are newly acknowledged in this ACK frame.
   This step detects any erroneous network remarking from ECT(0) to ECT(1) (or
   vice versa).
+  
+Another special case is when all packets are indicatd as CE marked,
+independtly of the initial codepode used, including Not-ECT. In this case
+it could be a network element overwriting the ECN field of all packets and

Let's not say why we think this is happening and go straight to the action:

> If a peer indicates that all received packets are ECN-CE marked, endpoints MAY treat this as an ECN validation failure and ignore any ECN-CE counts in acknowledgments.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3455#pullrequestreview-358633335